From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmPx4-0001Z7-Vj for qemu-devel@nongnu.org; Wed, 14 Oct 2015 13:35:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmPwz-0005pT-0G for qemu-devel@nongnu.org; Wed, 14 Oct 2015 13:34:58 -0400 References: <561E910C.2090204@redhat.com> From: Max Reitz Message-ID: <561E9233.8090207@redhat.com> Date: Wed, 14 Oct 2015 19:34:43 +0200 MIME-Version: 1.0 In-Reply-To: <561E910C.2090204@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6MVdeoHLmxbtr89K7EP5e1TamVJPpxNBm" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/3] block: Use bdrv_lookup_bs() instead of bdrv_find_node() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, qemu-block@nongnu.org, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6MVdeoHLmxbtr89K7EP5e1TamVJPpxNBm Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 14.10.2015 19:29, Max Reitz wrote: > On 14.10.2015 15:16, Jeff Cody wrote: >> This is a precursor to making bdrv_find_node() static, and internal >> to block.c >> >> To find a BlockDriverState interface, it can be done via blk_by_name()= , >> bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place= >> of the other two, in the instances where we are only concerned with >> the BlockDriverState. >> >> There is no benefit in calling bdrv_find_node() directly. This patch >> replaces all calls to bdrv_find_node() outside of block.c with >> bdrv_lookup_bs(). >> >> Signed-off-by: Jeff Cody >> --- >> block/block-backend.c | 2 +- >> block/mirror.c | 2 +- >> block/write-threshold.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > Reviewed-by: Max Reitz Oh, wait, on patch 2 gcc tells me I should take that back. If this series is based on Berto's series, that means it's also based on my BlockBackend series, and that one adds another instance of bdrv_find_node= (). Since I'll have to send a v7 anyway, I'll make it a bdrv_lookup_bs() there, so my R-b stands. Max --6MVdeoHLmxbtr89K7EP5e1TamVJPpxNBm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWHpIzAAoJEDuxQgLoOKytIgQH/0h3uixAyrbttJO2LCJa04H4 m8u7vzXditLUQEz+OGWcjuC+T8+sQ4H/YHdi8yLKZBFu+uRH4WXNpFPd8dKyQ1F9 U8ZgW4fp3IADw5hqXTypxcHOFN7QRH/bQV891sfVWP4TXHxNx8eWyY2O/fWWeJdM 0LVPojvew0jvazLkVIwNlGUEzTis+7xr6H8fnYtEGIdCJ90q+2TNn6pTj4s065Kp nhIMxb7gOXtn3AIvfLcAwtx9nNwRn4axDOytyn0Ta4dLCupaOP+MSeQ6CFYB/VoR 3RbybFVbFGKtJ9S2yUoEDppzqCUTGsPEKF2qwRsbflShdiej2ViJ48RE7TyL4Wo= =S1HD -----END PGP SIGNATURE----- --6MVdeoHLmxbtr89K7EP5e1TamVJPpxNBm--