From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: samuel.thibault@ens-lyon.org
Subject: Re: [Qemu-devel] [PATCH v2 06/21] qemu-char: convert parallel backend to data-driven creation
Date: Wed, 14 Oct 2015 14:52:03 -0600 [thread overview]
Message-ID: <561EC073.4030402@redhat.com> (raw)
In-Reply-To: <1444838064-14481-2-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On 10/14/2015 09:54 AM, Paolo Bonzini wrote:
> Conversion to Error * brings better error messages; before:
>
> qemu-system-x86_64: -chardev id=serial,backend=parallel,path=vl.c: Failed to create chardev
>
> After:
>
> qemu-system-x86_64: -chardev id=serial,backend=parallel,path=vl.c: not a parallel port: Inappropriate ioctl for device
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> qemu-char.c | 28 ++++++++++++++++++----------
> 1 file changed, 18 insertions(+), 10 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-14 20:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 15:54 [Qemu-devel] [PATCH v2 00/21] qemu-char: refactoring of chardev creation Paolo Bonzini
2015-10-14 15:54 ` [Qemu-devel] [PATCH v2 06/21] qemu-char: convert parallel backend to data-driven creation Paolo Bonzini
2015-10-14 20:52 ` Eric Blake [this message]
2015-10-14 15:54 ` [Qemu-devel] [PATCH v2 07/21] qemu-char: convert pipe " Paolo Bonzini
2015-10-14 20:53 ` Eric Blake
2015-10-14 15:54 ` [Qemu-devel] [PATCH v2 14/21] qemu-char: convert braille " Paolo Bonzini
2015-10-14 20:53 ` Eric Blake
2015-10-14 16:18 ` [Qemu-devel] [PATCH v2 00/21] qemu-char: refactoring of chardev creation Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561EC073.4030402@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).