From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Sergey Fedorov <serge.fdrv@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint
Date: Thu, 15 Oct 2015 08:02:50 +1100 [thread overview]
Message-ID: <561EC2FA.40901@twiddle.net> (raw)
In-Reply-To: <CAFEAcA-TXvAUiU7P+tB8ThUgpZ1TxGYaWE2Xf=VJR7vUPR=z4g@mail.gmail.com>
On 10/15/2015 06:34 AM, Peter Maydell wrote:
> This is still the same cryptic comment we have in the
> targets which do do this. Can we have something
> that is a bit more explanatory about what is going on and
> why we need to do this, please?
Suggestions?
> (Also explaining what the number you need to advance by
> should be would be helpful for people writing new targets
> in future.)
The number needed for advancing *need* only be 1, but I've continued with the
existing tradition of advancing by the minimum instruction size.
r~
next prev parent reply other threads:[~2015-10-14 21:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 22:10 [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint Richard Henderson
2015-10-14 9:04 ` Sergey Fedorov
2015-10-14 19:34 ` Peter Maydell
2015-10-14 21:02 ` Richard Henderson [this message]
2015-10-15 16:36 ` Peter Maydell
2015-10-16 1:14 ` Richard Henderson
2015-10-16 7:33 ` Peter Maydell
2015-10-16 14:08 ` Sergey Fedorov
2015-10-16 16:36 ` Sergey Fedorov
2015-10-16 18:03 ` Sergey Fedorov
2015-10-18 22:46 ` Richard Henderson
2015-10-19 11:04 ` Sergey Fedorov
2015-10-19 17:04 ` Richard Henderson
2015-10-19 17:26 ` Sergey Fedorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561EC2FA.40901@twiddle.net \
--to=rth@twiddle.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).