From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmTCQ-0002Dc-Aj for qemu-devel@nongnu.org; Wed, 14 Oct 2015 17:03:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmTCN-0008Fi-1B for qemu-devel@nongnu.org; Wed, 14 Oct 2015 17:03:02 -0400 Received: from mail-pa0-x236.google.com ([2607:f8b0:400e:c03::236]:33365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmTCM-0008FY-Rg for qemu-devel@nongnu.org; Wed, 14 Oct 2015 17:02:58 -0400 Received: by pabrc13 with SMTP id rc13so64505409pab.0 for ; Wed, 14 Oct 2015 14:02:58 -0700 (PDT) Sender: Richard Henderson References: <1444774253-10492-1-git-send-email-rth@twiddle.net> From: Richard Henderson Message-ID: <561EC2FA.40901@twiddle.net> Date: Thu, 15 Oct 2015 08:02:50 +1100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Sergey Fedorov , QEMU Developers On 10/15/2015 06:34 AM, Peter Maydell wrote: > This is still the same cryptic comment we have in the > targets which do do this. Can we have something > that is a bit more explanatory about what is going on and > why we need to do this, please? Suggestions? > (Also explaining what the number you need to advance by > should be would be helpful for people writing new targets > in future.) The number needed for advancing *need* only be 1, but I've continued with the existing tradition of advancing by the minimum instruction size. r~