From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmUhL-0003a0-5d for qemu-devel@nongnu.org; Wed, 14 Oct 2015 18:39:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmUhH-0008Rf-SG for qemu-devel@nongnu.org; Wed, 14 Oct 2015 18:39:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmUhH-0008RZ-K2 for qemu-devel@nongnu.org; Wed, 14 Oct 2015 18:38:59 -0400 References: <1444853285-10643-1-git-send-email-mdroth@linux.vnet.ibm.com> <1444853285-10643-10-git-send-email-mdroth@linux.vnet.ibm.com> From: Eric Blake Message-ID: <561ED980.9030002@redhat.com> Date: Wed, 14 Oct 2015 16:38:56 -0600 MIME-Version: 1.0 In-Reply-To: <1444853285-10643-10-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N6cPswqkLjT4OXeA18MhiUSIRwbqwL9A9" Subject: Re: [Qemu-devel] [PATCH 09/12] qga: guest exec functionality List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Yuri Pudgorodskiy , "Denis V. Lunev" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N6cPswqkLjT4OXeA18MhiUSIRwbqwL9A9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/14/2015 02:08 PM, Michael Roth wrote: > From: Yuri Pudgorodskiy >=20 > Guest-exec rewriten in platform-independant style with glib spawn. s/rewriten/rewritten/ s/independant/independent/ >=20 > Child process is spawn asynchroneously and exit status can later s/asynchroneously/asynchronously/ > be picked up by guest-exec-status command. >=20 > stdin/stdout/stderr of the child now is redirected to /dev/null > Later we will add ability to specify stdin in guest-exec command > and to get collected stdout/stderr with guest-exec-status. >=20 > Signed-off-by: Yuri Pudgorodskiy > Signed-off-by: Denis V. Lunev > CC: Michael Roth > *use g_new0 in place of g_malloc for GuestExec struct > Signed-off-by: Michael Roth > --- > +## > +# @guest-exec: > +# > +# Execute a command in the guest > +# > +# @path: path or executable name to execute > +# @arg: #optional argument list to pass to executable > +# @env: #optional environment variables to pass to executable > +# @inp-data: #optional data to be passed to process stdin (base64 enco= ded) Should this be 'input-data' instead of abbreviating? > +# @capture-output: #optional bool flags to enable capture of > +# stdout/stderr of running process Might be worth mentioning that the default is false. > +# > +# Returns: PID on success. > +# > +# Since: 2.5 > +## > +{ 'command': 'guest-exec', > + 'data': { 'path': 'str', '*arg': ['str'], '*env': ['str'], > + '*inp-data': 'str', '*capture-output': 'bool' }, > + 'returns': 'GuestExec' } Are there any restrictions on how elements of env must behave, such as requiring an '=3D'? If so, does that mean we need any more structure than= a raw 'str', such as {'name':'str', 'value':'str'}? Or is that overkill?= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --N6cPswqkLjT4OXeA18MhiUSIRwbqwL9A9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWHtmBAAoJEKeha0olJ0NqK8sH/jK9oT1m1eMbpLGzcKiJ6kg/ qwt7KLklNy24YVCz+dWBOaUT8K8c7+ju3045ZB+S+wp7W6LgsjJruEaocbIofRpy tWrg1wNc/oiWxlfNDj3L1a5vZraVF3HTkZX1EefEMhM3LOA69/g4/e9mWlCbYDvp F0WTPagSsYtVeyCrzMVxqtfeKrKF9/Ci4y7ciHMZNabj2ZGmdf+wf7POtmC7OV3d 6v6x51dihGFkR1w12iKgVrddwLcnQj/WTpKpS4a0jY1vbuVjN66fZfOJjobjA3O0 Q6fNDr3Z3PpBUZKuGsot3J/4MrSfhiq66vwCQf+6zwt4Kq11Lwju+W6ntJvQt/A= =ejae -----END PGP SIGNATURE----- --N6cPswqkLjT4OXeA18MhiUSIRwbqwL9A9--