From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37135)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZmXbq-0001RN-As
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 21:45:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZmXbn-0002Az-0w
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 21:45:34 -0400
References: <1444814805-15071-1-git-send-email-mst@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <561F0536.2000002@redhat.com>
Date: Thu, 15 Oct 2015 09:45:26 +0800
MIME-Version: 1.0
In-Reply-To: <1444814805-15071-1-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] net: don't set native endianness
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel@redhat.com>, qemu-stable@nongnu.org, Greg Kurz <gkurz@linux.vnet.ibm.com>



On 10/14/2015 05:26 PM, Michael S. Tsirkin wrote:
> commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991
>     vhost-net: tell tap backend about the vnet endianness
> makes vhost net always try to set LE - even if that matches the
> native endian-ness.
>
> This makes it fail on older kernels on x86 without TUNSETVNETLE support.
>
> To fix, make qemu_set_vnet_le/qemu_set_vnet_be skip the
> ioctl if it matches the host endian-ness.
>
> Reported-by: Marcel Apfelbaum <marcel@redhat.com>
> Cc: Greg Kurz <gkurz@linux.vnet.ibm.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Acked-by: Jason Wang <jasowang@redhat.com>

> ---
>  net/net.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/net/net.c b/net/net.c
> index 28a5597..8e96011 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -517,20 +517,28 @@ void qemu_set_vnet_hdr_len(NetClientState *nc, int len)
>  
>  int qemu_set_vnet_le(NetClientState *nc, bool is_le)
>  {
> +#ifdef HOST_WORDS_BIGENDIAN
>      if (!nc || !nc->info->set_vnet_le) {
>          return -ENOSYS;
>      }
>  
>      return nc->info->set_vnet_le(nc, is_le);
> +#else
> +    return 0;
> +#endif
>  }
>  
>  int qemu_set_vnet_be(NetClientState *nc, bool is_be)
>  {
> +#ifdef HOST_WORDS_BIGENDIAN
> +    return 0;
> +#else
>      if (!nc || !nc->info->set_vnet_be) {
>          return -ENOSYS;
>      }
>  
>      return nc->info->set_vnet_be(nc, is_be);
> +#endif
>  }
>  
>  int qemu_can_send_packet(NetClientState *sender)