Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

[Jason Wang <jasowang@redhat.com>]

On 10/14/2015 10:12 PM, Michael S. Tsirkin wrote:
> On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote:
>> Amit Shah <amit.shah@redhat.com> wrote:
>>> We were announcing the dest host's IP as our new IP a bit too soon -- if
>>> there were errors detected after this announcement was done, the
>>> migration is failed and the VM could continue running on the src host --
>>> causing problems later.
>>>
>>> Move around the qemu_announce_self() call so it's done just before the
>>> VM is runnable.
>>>
>>> Signed-off-by: Amit Shah <amit.shah@redhat.com>
>> Reviewed-by: Juan Quintela <quintela@redhat.com>
>>
>> applied.
>>
>> I have the same question than Dave, but also agree that this is a
>> movement in the right direction.
>>
>> Why it is not only needed when we do a vm_start()?
> It's a complex question.  We don't want to do this on each
> vmstop/vmcont. But maybe we want to, on the 1st vmstart after
> qemu is started.

Yes, so may be better to do this when autostart is true?

>
>> And why we can't delay it until that happens?
>>
>> Later, Juan.