From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmXkd-0005DY-Mp for qemu-devel@nongnu.org; Wed, 14 Oct 2015 21:54:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmXka-0003u9-H0 for qemu-devel@nongnu.org; Wed, 14 Oct 2015 21:54:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmXka-0003u5-B2 for qemu-devel@nongnu.org; Wed, 14 Oct 2015 21:54:36 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id E5847C0BFD00 for ; Thu, 15 Oct 2015 01:54:35 +0000 (UTC) References: <18ab6aea9a24a21bf2686a2ab220434951d53dc0.1444824439.git.amit.shah@redhat.com> <87r3kxpovo.fsf@neno.neno> <20151014165126-mutt-send-email-mst@redhat.com> From: Jason Wang Message-ID: <561F0758.7050101@redhat.com> Date: Thu, 15 Oct 2015 09:54:32 +0800 MIME-Version: 1.0 In-Reply-To: <20151014165126-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Juan Quintela Cc: Amit Shah , qemu list , "Dr. David Alan Gilbert" On 10/14/2015 10:12 PM, Michael S. Tsirkin wrote: > On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: >> Amit Shah wrote: >>> We were announcing the dest host's IP as our new IP a bit too soon -- if >>> there were errors detected after this announcement was done, the >>> migration is failed and the VM could continue running on the src host -- >>> causing problems later. >>> >>> Move around the qemu_announce_self() call so it's done just before the >>> VM is runnable. >>> >>> Signed-off-by: Amit Shah >> Reviewed-by: Juan Quintela >> >> applied. >> >> I have the same question than Dave, but also agree that this is a >> movement in the right direction. >> >> Why it is not only needed when we do a vm_start()? > It's a complex question. We don't want to do this on each > vmstop/vmcont. But maybe we want to, on the 1st vmstart after > qemu is started. Yes, so may be better to do this when autostart is true? > >> And why we can't delay it until that happens? >> >> Later, Juan.