From: Eric Blake <eblake@redhat.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PULL 1/3] Migration: Generate the completed event only when we complete
Date: Thu, 15 Oct 2015 08:46:56 -0600 [thread overview]
Message-ID: <561FBC60.5080705@redhat.com> (raw)
In-Reply-To: <1444890480-6371-2-git-send-email-quintela@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
On 10/15/2015 12:27 AM, Juan Quintela wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The current migration-completed event is generated a bit too early,
> which means that an eager libvirt that's ready to go as soon
> as it sees the event ends up racing with the actual end of migration.
>
> This corresponds to RH bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=1271145
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
> xSigned-off-by: Juan Quintela <quintela@redhat.com>
Will the 'x' screw up tools looking at this line?
> ---
> migration/migration.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-15 14:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 6:27 [Qemu-devel] [PULL 0/3] Migration pull Juan Quintela
2015-10-15 6:27 ` [Qemu-devel] [PULL 1/3] Migration: Generate the completed event only when we complete Juan Quintela
2015-10-15 14:46 ` Eric Blake [this message]
2015-10-15 15:07 ` Christian Borntraeger
2015-10-15 16:12 ` Dr. David Alan Gilbert
2015-10-16 8:13 ` Juan Quintela
2015-10-15 6:27 ` [Qemu-devel] [PULL 2/3] migration: announce VM's new home just before VM is runnable Juan Quintela
2015-10-15 6:28 ` [Qemu-devel] [PULL 3/3] migration: fix deadlock Juan Quintela
2015-10-16 15:23 ` [Qemu-devel] [PULL 0/3] Migration pull Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561FBC60.5080705@redhat.com \
--to=eblake@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).