From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmjoC-0002tV-Vm for qemu-devel@nongnu.org; Thu, 15 Oct 2015 10:47:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zmjo6-0003Xr-Uj for qemu-devel@nongnu.org; Thu, 15 Oct 2015 10:47:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zmjo6-0003Xm-Oc for qemu-devel@nongnu.org; Thu, 15 Oct 2015 10:47:02 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 3AD1E8F27B for ; Thu, 15 Oct 2015 14:47:02 +0000 (UTC) References: <1444890480-6371-1-git-send-email-quintela@redhat.com> <1444890480-6371-2-git-send-email-quintela@redhat.com> From: Eric Blake Message-ID: <561FBC60.5080705@redhat.com> Date: Thu, 15 Oct 2015 08:46:56 -0600 MIME-Version: 1.0 In-Reply-To: <1444890480-6371-2-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Bt9oC7cfGCF3Ruw069G3U2GJPF0JKcC0i" Subject: Re: [Qemu-devel] [PULL 1/3] Migration: Generate the completed event only when we complete List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Bt9oC7cfGCF3Ruw069G3U2GJPF0JKcC0i Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/15/2015 12:27 AM, Juan Quintela wrote: > From: "Dr. David Alan Gilbert" >=20 > The current migration-completed event is generated a bit too early, > which means that an eager libvirt that's ready to go as soon > as it sees the event ends up racing with the actual end of migration. >=20 > This corresponds to RH bug: > https://bugzilla.redhat.com/show_bug.cgi?id=3D1271145 >=20 > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Juan Quintela > Reviewed-by: Amit Shah > xSigned-off-by: Juan Quintela Will the 'x' screw up tools looking at this line? > --- > migration/migration.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Bt9oC7cfGCF3Ruw069G3U2GJPF0JKcC0i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWH7xhAAoJEKeha0olJ0Nq70QH/jUs0HDGoOr8HU0FmIZ2PSri Ty8n6NGjMIcOFwwPdf2vk4e+/zGZJCFFQHHKbzxd62gVbpG2DHewkYeGLSU3+pBM kVSEDLGPzCNKHAqQAtdGhQvH/momJE5z4p8w9bbcnKtapRu7zHpu2frjpRJT1ckp ZKf7Z3+DlD+Ntqry7xyju2fPWm8ryI+1bcg17NfQfgy2KgGypnEdo0NGRtRUcL4x XI/UgD9DLywgK4O4fmT8yweTfhtfxuaA4ilnq09oyXeACLhzhfniG9qKNdLEhPKh +WJpZVe30SUQnejnDQPiVTc+UzGH1Kscsvqwh2dWg2xIohjenw8u5fpyAP1MmSc= =sq6O -----END PGP SIGNATURE----- --Bt9oC7cfGCF3Ruw069G3U2GJPF0JKcC0i--