From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmkRh-0006M5-UI for qemu-devel@nongnu.org; Thu, 15 Oct 2015 11:27:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmkRc-0000lm-WF for qemu-devel@nongnu.org; Thu, 15 Oct 2015 11:27:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmkRc-0000lR-R5 for qemu-devel@nongnu.org; Thu, 15 Oct 2015 11:27:52 -0400 References: <1444918537-18107-1-git-send-email-armbru@redhat.com> <1444918537-18107-3-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <561FC5F7.10508@redhat.com> Date: Thu, 15 Oct 2015 09:27:51 -0600 MIME-Version: 1.0 In-Reply-To: <1444918537-18107-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ikm4vT6lKBFkOiDlw9XUo8xeq8kbvI6IF" Subject: Re: [Qemu-devel] [PATCH 2/6] qbool: Make conversion from QObject * accept null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ikm4vT6lKBFkOiDlw9XUo8xeq8kbvI6IF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/15/2015 08:15 AM, Markus Armbruster wrote: > qobject_to_qbool() crashes on null, which is a trap for the unwary. > Return null instead, and simplify a few callers. >=20 > Signed-off-by: Markus Armbruster > --- > qapi/qmp-input-visitor.c | 6 +++--- > qobject/qbool.c | 4 ++-- > qobject/qdict.c | 11 +++-------- > 3 files changed, 8 insertions(+), 13 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ikm4vT6lKBFkOiDlw9XUo8xeq8kbvI6IF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWH8X3AAoJEKeha0olJ0NqceQH+QHbk9xh/w+gkuypzO/dTF+f TGTSPMGxkc+f8uEqqR7AicslAowgZzInQheUbeyW7Vi2PUF7vIzXIR0DxOrQPu+V 7mdJU7We2o26MkY96Ygj/udIkJ+A1ICOYO9POrqptuevjnNXGTOaU7VSW15/kdGk k6kZm+jm+vvhW98wR04lQ0C5hTjqQHWKNefu0TtjbSWX0501zoSjJ+L6EMYmUiif EKKea2/QVPdfYv+m2P8Nog8sZpzgw27QTgOuKopaZzD23LSYW9/6WLii56J2N4y8 eeCrWAbwSwQ03oh2i4j+q6TqQAq149FC2C6z1ixeivb6JkuSM5ul8IiWA4S57S0= =fb7e -----END PGP SIGNATURE----- --ikm4vT6lKBFkOiDlw9XUo8xeq8kbvI6IF--