From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmkUC-0007tG-Qy for qemu-devel@nongnu.org; Thu, 15 Oct 2015 11:30:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmkU8-00024S-Ic for qemu-devel@nongnu.org; Thu, 15 Oct 2015 11:30:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmkU8-00024N-DA for qemu-devel@nongnu.org; Thu, 15 Oct 2015 11:30:28 -0400 References: <1444918537-18107-1-git-send-email-armbru@redhat.com> <1444918537-18107-4-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <561FC693.4070006@redhat.com> Date: Thu, 15 Oct 2015 09:30:27 -0600 MIME-Version: 1.0 In-Reply-To: <1444918537-18107-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Bu0uB25FIewn2Frtv3bIeF3STHk77tSj7" Subject: Re: [Qemu-devel] [PATCH 3/6] qdict: Make conversion from QObject * accept null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Bu0uB25FIewn2Frtv3bIeF3STHk77tSj7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/15/2015 08:15 AM, Markus Armbruster wrote: > qobject_to_qdict() crashes on null, which is a trap for the unwary. > Return null instead, and simplify a few callers. >=20 > Signed-off-by: Markus Armbruster > --- > qga/main.c | 11 +++-------- > qobject/qdict.c | 6 +++--- > 2 files changed, 6 insertions(+), 11 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Bu0uB25FIewn2Frtv3bIeF3STHk77tSj7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWH8aTAAoJEKeha0olJ0NqylsIAKVH2137K9I/Dmyd0x2pbS2j Ihl76U5uD15oQiqVGUQvaTumNnxk1df12MXp17af9LehRyiqq/3RDij6bM2kdqRL 5631/mCSBcND07XcjIacApihhmtocbSjXW0qOqBQHRss8mcWyE/4sCjzikeAAAJ4 uzWhw+OTiih2yiea1mFL4eGg3cCL3oV4wSw3KRpPe1zWK2cQg1k2lySm7JBpTxDP TU9wf2W+zeBCWIJLrZ96ih32zCk/4jlvn3u0U0u1gQYnkD30b050H6YUtv4r77c3 FFuHxleKFKDliMU4iMlWJ8qs9EI9HgNAhOh216zXmg58WZO/VqgDM0fuSgdtBYY= =YzNf -----END PGP SIGNATURE----- --Bu0uB25FIewn2Frtv3bIeF3STHk77tSj7--