From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zml6J-0005WC-3z for qemu-devel@nongnu.org; Thu, 15 Oct 2015 12:09:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zml6E-0002o0-2K for qemu-devel@nongnu.org; Thu, 15 Oct 2015 12:09:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zml6D-0002ni-Te for qemu-devel@nongnu.org; Thu, 15 Oct 2015 12:09:50 -0400 References: <1444918537-18107-1-git-send-email-armbru@redhat.com> <1444918537-18107-5-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <561FCFC7.9080407@redhat.com> Date: Thu, 15 Oct 2015 10:09:43 -0600 MIME-Version: 1.0 In-Reply-To: <1444918537-18107-5-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dAX0TnrJQeD63u5oewB4PEAoVEbLPskq5" Subject: Re: [Qemu-devel] [PATCH 4/6] qfloat qint: Make conversion from QObject * accept null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dAX0TnrJQeD63u5oewB4PEAoVEbLPskq5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/15/2015 08:15 AM, Markus Armbruster wrote: > qobject_to_qfloat() and qobject_to_qint() crash on null, which is a > trap for the unwary. Return null instead, and simplify a few callers. >=20 > Signed-off-by: Markus Armbruster > --- > qapi/qmp-input-visitor.c | 28 ++++++++++++++++------------ > qobject/qdict.c | 11 +++-------- > qobject/qfloat.c | 4 ++-- > qobject/qint.c | 4 ++-- > 4 files changed, 23 insertions(+), 24 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --dAX0TnrJQeD63u5oewB4PEAoVEbLPskq5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWH8/HAAoJEKeha0olJ0NqfAYH/2UoYypPju50nAO/ItmalVMe gSUxDckCAP9h1jlHfiNgNgOCtbyizVqq+033Y1DFGUtK8U1xA1MPaUZrcyelJtia DFDryDl93Rq2yDZxfo60dp0SQpSFZTEHSH6ggpOMFgio5TAKR6jL7mbqjBWp7AxH BWSCt1GjJ31DazZl5Dcy09KP9eg+C85XyjBw/AEqpz8ruEl5Hi1h15rdcBGl8Dtk SGE7QlfQgvEBVM4G4t87m3NwPmvgKQa0q1fWl/XiEMTDTnrMH3Yr+vKRQ0drIvZB o6dAMgc1WOrvh5v0on68cYYlpArG/OjOdlmIqmH/H7oa45BonVj0GcWjXhEbrUg= =69VX -----END PGP SIGNATURE----- --dAX0TnrJQeD63u5oewB4PEAoVEbLPskq5--