From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zml7V-0007GG-4H for qemu-devel@nongnu.org; Thu, 15 Oct 2015 12:11:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zml7P-0003Df-3Q for qemu-devel@nongnu.org; Thu, 15 Oct 2015 12:11:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zml7O-0003DN-8a for qemu-devel@nongnu.org; Thu, 15 Oct 2015 12:11:02 -0400 References: <1444918537-18107-1-git-send-email-armbru@redhat.com> <1444918537-18107-7-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <561FD014.9000700@redhat.com> Date: Thu, 15 Oct 2015 10:11:00 -0600 MIME-Version: 1.0 In-Reply-To: <1444918537-18107-7-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QXMKwQacxabDOD0BT4LfUtrmsewSpTuof" Subject: Re: [Qemu-devel] [PATCH 6/6] qstring: Make conversion from QObject * accept null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QXMKwQacxabDOD0BT4LfUtrmsewSpTuof Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/15/2015 08:15 AM, Markus Armbruster wrote: > qobject_to_qstring() crashes on null, which is a trap for the unwary. > Return null instead, and simplify a few callers. >=20 > Signed-off-by: Markus Armbruster > --- > qapi/qmp-input-visitor.c | 6 +++--- > qobject/qdict.c | 11 +++-------- > qobject/qstring.c | 4 ++-- > 3 files changed, 8 insertions(+), 13 deletions(-) >=20 > diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QXMKwQacxabDOD0BT4LfUtrmsewSpTuof Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWH9AVAAoJEKeha0olJ0NqeA8H/1YXd3fNWYNs94g67hQ4moFG 8f4udtIKKgMI9IV+7/xyl4BZL2NZbBtl9gH4vIX+JBnqKgsV7vvDaKn99748trjY /yjUOQp+cSIWPULaYBFZoO5IzOA2HJvqIICAy24byKTpDUlq9FImSEczHpR5eJ7B ffNddA2ZJwHjcSZJqfbwiP5NLVJ+8zSGhhO2j/uE/7xmfwG9hAGEUIafoHmrqKMq ZhOmk3LkpLF52t+64dqZAijzprbNvoUi5lksFggPTBPLIt9Zo3mOx4Ey3U4ueaUp HRkcTLFYvTW9z9hQptRrJOB9R5NoeccavDBVEj7ysWsWVznuAAtfT357W5z5BjA= =Ptgd -----END PGP SIGNATURE----- --QXMKwQacxabDOD0BT4LfUtrmsewSpTuof--