From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8ACAC43457 for ; Tue, 13 Oct 2020 14:49:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0477624898 for ; Tue, 13 Oct 2020 14:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q0AH2RwK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0477624898 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSLcI-0008Aq-Vv for qemu-devel@archiver.kernel.org; Tue, 13 Oct 2020 10:49:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSLaS-0006gg-Un for qemu-devel@nongnu.org; Tue, 13 Oct 2020 10:47:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSLaP-0004K3-S5 for qemu-devel@nongnu.org; Tue, 13 Oct 2020 10:47:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602600450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YfUEwha/ANIuR9EnKDdgWRUSQqF02uCk/zBJ2q/92gA=; b=Q0AH2RwKvOuieZdrU7kbn5UDPleT8vd7vdHoyCWe/M+jH/so+sRkX53qTyQ52FQ7/rJYjj r5QrDr4DXzXW/9zvPXpRJ7lrdNGAOH01ZrAVnsfnEuZ/iEu7pS5kRa3rr0GYdo11pgL64i GxzJ6mAhHAMaUjOOKVmaKgmv0McJQGI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-228-wSTzExo0MOyVhDFsJHFigQ-1; Tue, 13 Oct 2020 10:47:27 -0400 X-MC-Unique: wSTzExo0MOyVhDFsJHFigQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0181518A8229; Tue, 13 Oct 2020 14:47:25 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.193.164]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 07BA876671; Tue, 13 Oct 2020 14:47:16 +0000 (UTC) Subject: Re: [PATCH v2] migration/block-dirty-bitmap: fix uninitialized variable warning To: Chen Qun , qemu-devel@nongnu.org, qemu-trivial@nongnu.org References: <20201013123340.1850548-1-kuhn.chenqun@huawei.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <561a0092-3723-a95a-0208-d53cb475a532@redhat.com> Date: Tue, 13 Oct 2020 16:47:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20201013123340.1850548-1-kuhn.chenqun@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kjV2joCfSi2Vf97BHoKoXrIX0hPys0zkq" Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/13 03:04:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, ganqixin@huawei.com, vsementsov@virtuozzo.com, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, quintela@redhat.com, Li Qiang , dgilbert@redhat.com, Laurent Vivier , stefanha@redhat.com, Euler Robot , jsnow@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kjV2joCfSi2Vf97BHoKoXrIX0hPys0zkq Content-Type: multipart/mixed; boundary="R7FHN7jXUTJdNOfvEq3LXcZx8TryVjI74" --R7FHN7jXUTJdNOfvEq3LXcZx8TryVjI74 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 13.10.20 14:33, Chen Qun wrote: > A default value is provided for the variable 'bitmap_name' to avoid compi= ler warning. >=20 > The compiler show warning: > migration/block-dirty-bitmap.c:1090:13: warning: =E2=80=98bitmap_name=E2= =80=99 > may be used uninitialized in this function [-Wmaybe-uninitialized] > g_strlcpy(s->bitmap_name, bitmap_name, sizeof(s->bitmap_name)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > Cc: Vladimir Sementsov-Ogievskiy > Cc: Laurent Vivier > Cc: Li Qiang > --- > migration/block-dirty-bitmap.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) No objections, semantically, but... > diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitma= p.c > index 5bef793ac0..bcb79c04ce 100644 > --- a/migration/block-dirty-bitmap.c > +++ b/migration/block-dirty-bitmap.c > @@ -1064,15 +1064,13 @@ static int dirty_bitmap_load_header(QEMUFile *f, = DBMLoadState *s, > assert(nothing || s->cancelled || !!alias_map =3D=3D !!bitmap_alias_= map); > =20 > if (s->flags & DIRTY_BITMAP_MIG_FLAG_BITMAP_NAME) { > - const char *bitmap_name; > - > if (!qemu_get_counted_string(f, s->bitmap_alias)) { > error_report("Unable to read bitmap alias string"); > return -EINVAL; > } > =20 > - if (!s->cancelled) { > - if (bitmap_alias_map) { > + const char *bitmap_name =3D s->bitmap_alias; qemu=E2=80=99s coding style mandates declarations to be placed at the begin= ning of their block, so the declaration has to stay where it is. (Putting the assignment here looks reasonable.) > + if (!s->cancelled && bitmap_alias_map) { > bitmap_name =3D g_hash_table_lookup(bitmap_alias_map, > s->bitmap_alias); This block of course needs to be re-indented. Max > if (!bitmap_name) { > @@ -1081,9 +1079,6 @@ static int dirty_bitmap_load_header(QEMUFile *f, DB= MLoadState *s, > s->bs->node_name, s->node_alias); > cancel_incoming_locked(s); > } > - } else { > - bitmap_name =3D s->bitmap_alias; > - } > } > =20 > if (!s->cancelled) { >=20 --R7FHN7jXUTJdNOfvEq3LXcZx8TryVjI74-- --kjV2joCfSi2Vf97BHoKoXrIX0hPys0zkq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl+FvfMACgkQ9AfbAGHV z0CNSQf/fQzIWc4Cw8FWl6Nx1Ex8P6/qyW7OGmvGpI3cHvI0Y+UpeDpmUY6sOh13 sBNnFe74KYb7YwgD7KIts/tlM5sQQFq7oKLF3ELfKVGKslATHppuR0XUyAqyN7NV 0V+rYMbjmd/i5vfNtALH7PDgFmjnHDfkuh+OGp8fgb7dzP6gpVc8113lZKEDcVtJ BIcS0kDcKFiFkpi/NPK8bg+1r/M2y8+bAY+sAGvkZBa+sU9EVfeyCqDqHqXpGpMb RAXn1kWt6xyM9qq9/0x6yR7x8eSJi/SAEY3DMtpZwORqEBap4cX0QPQ2GRXj/i3w JLE57pqM2SZ/l/dqn29RqIEgd6ICIw== =BBrQ -----END PGP SIGNATURE----- --kjV2joCfSi2Vf97BHoKoXrIX0hPys0zkq--