From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76566EED603 for ; Fri, 15 Sep 2023 15:21:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhAd1-0001pb-2q; Fri, 15 Sep 2023 11:21:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhAcr-0001jb-8a for qemu-devel@nongnu.org; Fri, 15 Sep 2023 11:20:58 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhAcp-0004In-4F for qemu-devel@nongnu.org; Fri, 15 Sep 2023 11:20:56 -0400 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-68fb898ab3bso1867115b3a.3 for ; Fri, 15 Sep 2023 08:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1694791252; x=1695396052; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/c8yieboNB6oo1mu8ZkACI0svLfzvvTV7i2vZIioxzw=; b=aEFjuHzpu/HTsxMMkMGPOq6FSRkeHdp9AGVL9x+HvIvKhS8lJFaO+l2Sk4VM18l2kt S1p98e4zEpv4P9q1rxTXtlN9gJaE0Qma61hGWznlzLFc7he0LLoM6tdUB6YzCqHmWCzO KATkUjEcHawp+CD4iruU3y909YmlA+bNtdoBLkMfl9MuIP3+l2jgDLHazvb9YJgqXKl3 PFSLPgDenIwXyb9f27KHEFqyYwgaQElSwzPuEPErHpkPKhkdtWsTkxf/iZ5ugNYnMx6W fKJr/fYqxmfib8lSJBMZ8So1sq78MSj8Tbp4ZmJa5ImxJEz17Ux8cPkRFV+Mw1eU2OUP +/2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694791252; x=1695396052; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/c8yieboNB6oo1mu8ZkACI0svLfzvvTV7i2vZIioxzw=; b=XOU9G30uc55b0Q08+y2gtKdWe/ABtdPSww66uRktfIBGFHXy/dx+axiUpkDsq98uBX rdkHgv4UKMQgl3qBF8WClt84N1hs2/gZwYNezxHQzLyVHt9gG/lBnW9XuvSfzyoPlH5s NgtndjCMqAtJGHHwVtQrOUft4XI3sqPPmTQRi6kwKdtXowYEPKf66sxwyEcvQWfhRVHy SesSMnL2WiiPNiTSKvCkpeIe40VMFbfjvBFcUeDdqrpt9ULp3qUn4abV3joTVR0WlxgG HMaxoqaDUjwA1MNQRSUy3p8Qh1FXXMXzM58oRs5Rfb0pHjcYvrzh9Ogfx8Hu6vnco2pf A/DA== X-Gm-Message-State: AOJu0YwzKySDN/JLHatOJUSRaFXNGJIuoK2CZ2alneUwWwh77JxnljD/ J+R5DiWpMCm9wTBXGyvTAHhCKWToBrtOGPQtNsw= X-Google-Smtp-Source: AGHT+IEGzwW/4d4Bs56A/WRm7j4T8sgYlpdt8z9DxtjMDAWb6/tf9I3QEoiPKszLJbdDXkW5LyBbjg== X-Received: by 2002:a05:6a00:851:b0:690:42d5:4332 with SMTP id q17-20020a056a00085100b0069042d54332mr2285518pfk.6.1694791252653; Fri, 15 Sep 2023 08:20:52 -0700 (PDT) Received: from ?IPV6:2400:4050:a840:1e00:78d2:b862:10a7:d486? ([2400:4050:a840:1e00:78d2:b862:10a7:d486]) by smtp.gmail.com with ESMTPSA id n17-20020aa78a51000000b0068bc014f352sm3106609pfa.7.2023.09.15.08.20.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Sep 2023 08:20:52 -0700 (PDT) Message-ID: <561abf48-d72c-467d-94fd-54ffa1dfb512@daynix.com> Date: Sat, 16 Sep 2023 00:20:46 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer Content-Language: en-US To: Huang Rui , Gerd Hoffmann , "Michael S . Tsirkin" , Stefano Stabellini , Anthony PERARD , Antonio Caggiano , "Dr . David Alan Gilbert" , Robert Beckett , Dmitry Osipenko , =?UTF-8?Q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, Gurchetan Singh , Albert Esteve , ernunes@redhat.com, =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Alyssa Ross , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Xenia Ragiadakou , Pierre-Eric Pelloux-Prayer , Honglei Huang , Julia Zhang , Chen Jiqian , Antonio Caggiano References: <20230915111130.24064-1-ray.huang@amd.com> <20230915111130.24064-7-ray.huang@amd.com> From: Akihiko Odaki In-Reply-To: <20230915111130.24064-7-ray.huang@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: none client-ip=2607:f8b0:4864:20::42c; envelope-from=akihiko.odaki@daynix.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2023/09/15 20:11, Huang Rui wrote: > Patch "virtio-gpu: CONTEXT_INIT feature" has added the context_init > feature flags. > We would like to enable the feature with virglrenderer, so add to create > virgl renderer context with flags using context_id when valid. > > Originally-by: Antonio Caggiano > Signed-off-by: Huang Rui > --- > > V4 -> V5: > - Inverted patch 5 and 6 because we should configure > HAVE_VIRGL_CONTEXT_INIT firstly. (Philippe) > > hw/display/virtio-gpu-virgl.c | 13 +++++++++++-- > hw/display/virtio-gpu.c | 2 ++ > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c > index 8bb7a2c21f..312953ec16 100644 > --- a/hw/display/virtio-gpu-virgl.c > +++ b/hw/display/virtio-gpu-virgl.c > @@ -106,8 +106,17 @@ static void virgl_cmd_context_create(VirtIOGPU *g, > trace_virtio_gpu_cmd_ctx_create(cc.hdr.ctx_id, > cc.debug_name); > > - virgl_renderer_context_create(cc.hdr.ctx_id, cc.nlen, > - cc.debug_name); > + if (cc.context_init) { > +#ifdef HAVE_VIRGL_CONTEXT_INIT > + virgl_renderer_context_create_with_flags(cc.hdr.ctx_id, > + cc.context_init, > + cc.nlen, > + cc.debug_name); > + return; > +#endif This should deal with the case when context_init is set while HAVE_VIRGL_CONTEXT_INIT is not defined.