From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmrGg-0006DM-TY for qemu-devel@nongnu.org; Thu, 15 Oct 2015 18:45:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmrGd-00043i-ID for qemu-devel@nongnu.org; Thu, 15 Oct 2015 18:45:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmrGd-00043H-Cn for qemu-devel@nongnu.org; Thu, 15 Oct 2015 18:44:59 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 5CE9E344F62 for ; Thu, 15 Oct 2015 22:44:58 +0000 (UTC) References: <1444921716-9511-1-git-send-email-armbru@redhat.com> <1444921716-9511-4-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56202C69.9060105@redhat.com> Date: Thu, 15 Oct 2015 16:44:57 -0600 MIME-Version: 1.0 In-Reply-To: <1444921716-9511-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LW7WRGJt45vQ8Bu4aPEDsrRuVUURQRwHR" Subject: Re: [Qemu-devel] [PATCH 3/7] monitor: Switch from timer_new() to timer_new_ns() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, marcandre.lureau@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LW7WRGJt45vQ8Bu4aPEDsrRuVUURQRwHR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/15/2015 09:08 AM, Markus Armbruster wrote: > We don't actually care for the scale, so we can just as well use the > simpler interface. >=20 > Signed-off-by: Markus Armbruster > --- > monitor.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/monitor.c b/monitor.c > index ca201fd..baffd76 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -545,10 +545,9 @@ monitor_qapi_event_throttle(QAPIEvent event, int64= _t rate) > assert(rate * SCALE_MS <=3D INT64_MAX); A bit unrelated: Isn't this assertion risky, compared to: assert(rate <=3D INT64_MAX / SCALE_MS); > evstate->rate =3D rate * SCALE_MS; > evstate->qdict =3D NULL; > - evstate->timer =3D timer_new(QEMU_CLOCK_REALTIME, > - SCALE_MS, > - monitor_qapi_event_handler, > - evstate); > + evstate->timer =3D timer_new_ns(QEMU_CLOCK_REALTIME, > + monitor_qapi_event_handler, > + evstate); > } Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LW7WRGJt45vQ8Bu4aPEDsrRuVUURQRwHR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWICxpAAoJEKeha0olJ0NqxvsH/0peNkVikoO7WYa9orqcRHQ7 gL2moiXfTGMe1wgVcqxAzm50GrQuwoJY32rhm7UtqAniz4zRAk4/ttQFORlLd3o+ ZzTbkOSlD6ZXhI2ls6qWd70bGg3Wieo1Ext5ppSaCS+nWKrf3iCBxEOHsb8hKNG6 rpdX7Lj7TG0XKv5ntlzszKJ3HGhOCiNcLQQ+ws06jt3F6JAU8SJpp6MAixL9EVUy vlr3bakpI51irQfdAmu5u+2SJeDtqlZCsUOgqdnnzwOidEiRLRh4v8Ru6U8bn67u COWY+IdFghu9lSK2rWJznrdvQci0X8475Z7CCDtail7IaXagBNDj1figiiZ+5Hw= =eSh9 -----END PGP SIGNATURE----- --LW7WRGJt45vQ8Bu4aPEDsrRuVUURQRwHR--