From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zmzo6-0004YV-1P for qemu-devel@nongnu.org; Fri, 16 Oct 2015 03:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zmzo2-0007vz-1m for qemu-devel@nongnu.org; Fri, 16 Oct 2015 03:52:05 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:34164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zmzo1-0007vn-Qh for qemu-devel@nongnu.org; Fri, 16 Oct 2015 03:52:01 -0400 Received: by lffv3 with SMTP id v3so6896621lff.1 for ; Fri, 16 Oct 2015 00:52:01 -0700 (PDT) Sender: Paolo Bonzini References: <1444979273-6587-1-git-send-email-den@openvz.org> <1444979273-6587-10-git-send-email-den@openvz.org> From: Paolo Bonzini Message-ID: <5620AC9E.4050905@redhat.com> Date: Fri, 16 Oct 2015 09:51:58 +0200 MIME-Version: 1.0 In-Reply-To: <1444979273-6587-10-git-send-email-den@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 9/9] kvm/x86: Hyper-V kvm exit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: kvm@vger.kernel.org, Gleb Natapov , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, rkagan@virtuozzo.com, Andrey Smetanin , Vitaly Kuznetsov , "K. Y. Srinivasan" On 16/10/2015 09:07, Denis V. Lunev wrote: > > + /* KVM_EXIT_HYPERV */ > + struct kvm_hyperv_exit hyperv; > +Indicates that the VCPU exits into userspace to process some tasks > +related with Hyper-V emulation. Currently used to synchronize modified > +Hyper-V SynIC state with userspace. > + The documentation should include the definition of the struct and the definition of the subtypes (currently KVM_EXIT_HYPERV_SYNIC only). Documentation for KVM_CAP_HYPERV_SINIC and KVM_IRQ_ROUTING_HV_SINT is missing, too. Finally, it would be better to have unit tests in kvm-unit-tests. Either this or QEMU support is a requirement for merging, and the unit tests are probably easier. But apart from this, the series looks great and I'm already applying it to kvm/queue so that it gets some more testing. Paolo