From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48144)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zn0eu-0000jC-UF
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 04:46:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zn0eu-0005PR-1V
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 04:46:40 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1444984830-39886-1-git-send-email-cornelia.huck@de.ibm.com>
	<5620B849.80202@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5620B967.7000000@redhat.com>
Date: Fri, 16 Oct 2015 10:46:31 +0200
MIME-Version: 1.0
In-Reply-To: <5620B849.80202@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: switch off scsi-passthrough by
	default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jasowang@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com, mst@redhat.com



On 16/10/2015 10:41, Paolo Bonzini wrote:
> 
> 
> On 16/10/2015 10:40, Cornelia Huck wrote:
>> --- a/hw/s390x/s390-virtio-ccw.c
>> +++ b/hw/s390x/s390-virtio-ccw.c
>> @@ -272,6 +272,10 @@ static const TypeInfo ccw_machine_info = {
>>              .driver   = "vhost-scsi-ccw",\
>>              .property = "max_revision",\
>>              .value    = "0",\
>> +        },{\
>> +            .driver   = "virtio-blk-ccw",\
>> +            .property = "scsi",\
>> +            .value    = "true",\
>>          },
>>  
>>  static void ccw_machine_2_4_class_init(ObjectClass *oc, void *data)
>> diff --git a/include/hw/compat.h b/include/hw/compat.h
>> index 095de5d..bbf1ab2 100644
>> --- a/include/hw/compat.h
>> +++ b/include/hw/compat.h
>> @@ -2,7 +2,11 @@
>>  #define HW_COMPAT_H
>>  
>>  #define HW_COMPAT_2_4 \
>> -        /* empty */
>> +        {\
>> +            .driver   = "virtio-blk-pci",\
>> +            .property = "scsi",\
>> +            .value    = "true",\
>> +        },
>>  
>>  #define HW_COMPAT_2_3 \
>>          {\
>>
> 
> s390 should use HW_COMPAT_2_4 as well.  Otherwise looks good.

Hmm, ECONCISE probably.  Sorry.

I mean that virtio-blk-ccw's scsi property should IMO go in
HW_COMPAT_2_4 as well.

But I noticed now that:

* if it works it would be even better if the compat property used
virtio-blk-device;

* a new pseries-2.4 machine also needs to be created.

Thanks,

Paolo