From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56729)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1Zn3AH-00009g-8n
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 07:27:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1Zn3AD-0001CE-TR
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 07:27:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42190)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1Zn3AD-0001Bu-NV
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 07:27:09 -0400
References: <1444837878-11602-1-git-send-email-knut.omang@oracle.com>
	<1444837878-11602-4-git-send-email-knut.omang@oracle.com>
	<20151016112940-mutt-send-email-mst@redhat.com>
	<1444989399.4614.16.camel@oracle.com>
	<20151016135118-mutt-send-email-mst@redhat.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <5620DF07.20809@redhat.com>
Date: Fri, 16 Oct 2015 14:27:03 +0300
MIME-Version: 1.0
In-Reply-To: <20151016135118-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 3/4] pcie: Add some SR/IOV API
 documentation in docs/pcie_sriov.txt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Knut Omang <knut.omang@oracle.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>, qemu-devel@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@web.de>, Paolo Bonzini <pbonzini@redhat.com>, Dotan Barak <dotanba@gmail.com>, Richard Henderson <rth@twiddle.net>

On 10/16/2015 01:54 PM, Michael S. Tsirkin wrote:
> On Fri, Oct 16, 2015 at 11:56:39AM +0200, Knut Omang wrote:
>> But feel free to just skip this patch, the most important is to get the
>> generic SR/IOV code in there for others to use.
>
> That's my question. Is it for others to use or are you going to use it
> youself?
>
> If you plan to e.g. complete igb to the point where Linux can use it,
> then I'll merge this.
> BTW for igb it might be easier to copy out e1000 code, at least that's what
> linux guest drivers did.
>
> Alternatively, if someone  on list is interested in using this,
> please review and ack.
>

Hi,

Even if nobody is actually going to implement an SR-IOV enabled device
on top of this really soon, having it in QEMU should be handy.

I know at least a hardware vendor that used those bits to emulate their SR-IOV device.
Sadly their code will not come to QEMU, at least not so soon. (I'll ask at least for a "tested-by" tag)

Maybe somebody will want to enable SR-IOV for virtio :)

This is why I proposed to have a "how-to" doc for the first implementation.
The implementer will choose then how to deal with this doc.

I'll go over the code again and add my "Reviewed-by".

Thanks!
Marcel