From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn48t-0008Ix-W5 for qemu-devel@nongnu.org; Fri, 16 Oct 2015 08:29:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zn48s-0001kH-Ms for qemu-devel@nongnu.org; Fri, 16 Oct 2015 08:29:51 -0400 References: <1444992364-28715-1-git-send-email-famz@redhat.com> From: Eric Blake Message-ID: <5620EDB7.50201@redhat.com> Date: Fri, 16 Oct 2015 06:29:43 -0600 MIME-Version: 1.0 In-Reply-To: <1444992364-28715-1-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1Xgv9XJCqVc7073fLDN4V3qWcOILoIFnE" Subject: Re: [Qemu-devel] [PATCH] blkdebug: Don't confuse image as backing file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1Xgv9XJCqVc7073fLDN4V3qWcOILoIFnE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/16/2015 04:46 AM, Fam Zheng wrote: > The word "backing file" nowadays refers to the backing_hd in the > external snapshot sense (i.e. bs->backing_hd), instead of the file sens= e > (bs->file). Correct the comment to use the right term. >=20 > Signed-off-by: Fam Zheng > --- > block/blkdebug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/block/blkdebug.c b/block/blkdebug.c > index bc247f4..54650a7 100644 > --- a/block/blkdebug.c > +++ b/block/blkdebug.c > @@ -426,7 +426,7 @@ static int blkdebug_open(BlockDriverState *bs, QDic= t *options, int flags, > /* Set initial state */ > s->state =3D 1; > =20 > - /* Open the backing file */ > + /* Open the image file */ > assert(bs->file =3D=3D NULL); > ret =3D bdrv_open_image(&bs->file, qemu_opt_get(opts, "x-image"), = options, "image", > bs, &child_file, false, &local_err); >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1Xgv9XJCqVc7073fLDN4V3qWcOILoIFnE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWIO23AAoJEKeha0olJ0NqKzoIAI0Q0LJ4Q2L+fPnfN8qvKxwb 8+Oh+0rmZKHJkz5dtL1p2yrGgpvcMfYCj8niyj3Z6YPHjyxQz5HGV9Xoz46qF2iZ KtVvJXcdxnGVqEVRbZNZ6l9XEL3DZqj6K+HS0RlCCOVFw2m2kP6/yWlWcjfKmHI+ yt342MDnRrcS5XtS5aP9iV17sPORK3+mcklaAxY6KjLeF/2fuW0EYD3thbMmFDjf v6x9HBgzpRxf1HozHPQQzfqTpzuVz5H5wx1q51LbuqXT/6/eBbYce0edDqzfoUJm Ox9l7AU4Ka29pllWZP8vmMcXAEDP3c5KF4tuafCGHXFTc5uiKLh8VVg0yVRyIMI= =sHPh -----END PGP SIGNATURE----- --1Xgv9XJCqVc7073fLDN4V3qWcOILoIFnE--