From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, "Denis V. Lunev" <den@openvz.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Pavel Butsykin <pbutsykin@virtuozzo.com>
Subject: Re: [Qemu-devel] What's the intended use of log.h logging?
Date: Fri, 16 Oct 2015 14:48:19 +0200 [thread overview]
Message-ID: <5620F213.1010908@redhat.com> (raw)
In-Reply-To: <87oafzdmck.fsf_-_@blackfin.pond.sub.org>
On 16/10/2015 14:33, Markus Armbruster wrote:
> Looks like this is basically TCG with a couple of random LOG_UNIMP
> and LOG_GUEST_ERROR thrown in. It's definitely not a general purpose
> QEMU log in its current state.
I think these could become error_report.
Some others (e.g. LOG_IOPORT) can be removed.
LOG_MMU seems to be mostly a ppc thing, could also become a tracepoint.
Likewise for LOG_PCALL and perhaps LOG_INT.
However, we should at the same time add some functionality to enable
tracepoints more easily, and perhaps enable the stderr tracing backend
by default upstream (downstream can enable stderr+stap; or if they care
a lot about performance disable stderr in favor of stap only).
Paolo
next prev parent reply other threads:[~2015-10-16 12:48 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 7:30 [Qemu-devel] [PATCH 0/3] QEMU logging improvements Denis V. Lunev
2015-10-15 7:30 ` [Qemu-devel] [PATCH 1/3] log: improve performance of qemu_log and qemu_log_mask if disabled Denis V. Lunev
2015-10-15 17:23 ` Alex Bennée
2015-10-15 17:40 ` Denis V. Lunev
2015-10-15 18:36 ` Alex Bennée
2015-10-16 7:17 ` Markus Armbruster
2015-10-16 7:45 ` Denis V. Lunev
2015-10-16 11:02 ` Markus Armbruster
2015-10-16 11:08 ` Denis V. Lunev
2015-10-15 7:30 ` [Qemu-devel] [PATCH 2/3] log: report hmp/qmp command and qmp event Denis V. Lunev
2015-10-16 7:34 ` Markus Armbruster
2015-10-16 9:51 ` Pavel Butsykin
2015-10-16 12:35 ` Markus Armbruster
2015-10-16 12:33 ` [Qemu-devel] What's the intended use of log.h logging? (was: [PATCH 2/3] log: report hmp/qmp command and qmp event) Markus Armbruster
2015-10-16 12:48 ` Paolo Bonzini [this message]
2015-10-16 12:54 ` [Qemu-devel] What's the intended use of log.h logging? Peter Maydell
2015-10-16 13:00 ` Paolo Bonzini
2015-10-16 13:38 ` Denis V. Lunev
2015-10-16 13:26 ` Daniel P. Berrange
2015-10-16 13:29 ` Peter Maydell
2015-10-16 13:30 ` Paolo Bonzini
2015-10-16 13:36 ` Peter Maydell
2015-10-16 14:17 ` Paolo Bonzini
2015-10-16 14:31 ` Peter Maydell
2015-10-16 15:27 ` Paolo Bonzini
2015-10-19 13:17 ` Markus Armbruster
2015-10-19 13:19 ` Paolo Bonzini
2015-10-19 13:54 ` Peter Maydell
2015-10-16 12:51 ` [Qemu-devel] What's the intended use of log.h logging? (was: [PATCH 2/3] log: report hmp/qmp command and qmp event) Peter Maydell
2015-10-19 14:29 ` [Qemu-devel] What's the intended use of log.h logging? Markus Armbruster
2015-10-19 14:41 ` Peter Maydell
2015-10-19 16:57 ` Dr. David Alan Gilbert
2015-10-19 17:02 ` Dr. David Alan Gilbert
2015-10-20 13:11 ` Kevin Wolf
2015-10-16 14:36 ` [Qemu-devel] What's the intended use of log.h logging? (was: [PATCH 2/3] log: report hmp/qmp command and qmp event) Alex Bennée
2015-10-19 14:52 ` [Qemu-devel] What's the intended use of log.h logging? Markus Armbruster
2015-10-19 14:57 ` Peter Maydell
2015-10-21 10:41 ` [Qemu-devel] What's the intended use of log.h logging? (was: [PATCH 2/3] log: report hmp/qmp command and qmp event) Stefan Hajnoczi
2015-10-21 11:10 ` [Qemu-devel] What's the intended use of log.h logging? Denis V. Lunev
2015-10-21 12:22 ` [Qemu-devel] What's the intended use of log.h logging? (was: [PATCH 2/3] log: report hmp/qmp command and qmp event) Peter Maydell
2015-10-22 12:26 ` Stefan Hajnoczi
2015-10-22 13:05 ` [Qemu-devel] What's the intended use of log.h logging? Paolo Bonzini
2015-10-15 7:30 ` [Qemu-devel] [PATCH 3/3] log: adds a timestamp to each log entry Denis V. Lunev
2015-10-16 7:49 ` Markus Armbruster
2015-10-16 9:55 ` Pavel Butsykin
2015-10-16 11:33 ` Markus Armbruster
2015-10-15 14:49 ` [Qemu-devel] [PATCH 0/3] QEMU logging improvements Kashyap Chamarthy
2015-10-15 15:18 ` Pavel Butsykin
2015-10-15 16:02 ` Kashyap Chamarthy
2015-10-26 9:16 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5620F213.1010908@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=lcapitulino@redhat.com \
--cc=pbutsykin@virtuozzo.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).