From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn4Qt-0008Q8-Dv for qemu-devel@nongnu.org; Fri, 16 Oct 2015 08:48:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zn4Qn-0000gP-WF for qemu-devel@nongnu.org; Fri, 16 Oct 2015 08:48:25 -0400 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:35386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn4Qn-0000fv-Qe for qemu-devel@nongnu.org; Fri, 16 Oct 2015 08:48:21 -0400 Received: by wicll6 with SMTP id ll6so8383021wic.0 for ; Fri, 16 Oct 2015 05:48:21 -0700 (PDT) Sender: Paolo Bonzini References: <1444894224-9542-1-git-send-email-den@openvz.org> <1444894224-9542-3-git-send-email-den@openvz.org> <87oafzdmck.fsf_-_@blackfin.pond.sub.org> From: Paolo Bonzini Message-ID: <5620F213.1010908@redhat.com> Date: Fri, 16 Oct 2015 14:48:19 +0200 MIME-Version: 1.0 In-Reply-To: <87oafzdmck.fsf_-_@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] What's the intended use of log.h logging? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , "Denis V. Lunev" Cc: Peter Maydell , Luiz Capitulino , qemu-devel@nongnu.org, Stefan Hajnoczi , Pavel Butsykin On 16/10/2015 14:33, Markus Armbruster wrote: > Looks like this is basically TCG with a couple of random LOG_UNIMP > and LOG_GUEST_ERROR thrown in. It's definitely not a general purpose > QEMU log in its current state. I think these could become error_report. Some others (e.g. LOG_IOPORT) can be removed. LOG_MMU seems to be mostly a ppc thing, could also become a tracepoint. Likewise for LOG_PCALL and perhaps LOG_INT. However, we should at the same time add some functionality to enable tracepoints more easily, and perhaps enable the stderr tracing backend by default upstream (downstream can enable stderr+stap; or if they care a lot about performance disable stderr in favor of stap only). Paolo