* [Qemu-devel] [PATCH] hw/mips_malta: Fix KVM PC initialisation
@ 2015-10-12 16:54 James Hogan
2015-10-13 15:46 ` Aurelien Jarno
2015-10-16 14:58 ` Leon Alrae
0 siblings, 2 replies; 3+ messages in thread
From: James Hogan @ 2015-10-12 16:54 UTC (permalink / raw)
To: qemu-devel; +Cc: James Hogan, Leon Alrae, Aurelien Jarno, Paul Burton
Commit 71c199c81d29 ("mips_malta: provide ememsize env variable to
kernels") changed the meaning of loaderparams.ram_size to be the whole
of RAM rather than just the low part below where the boot code is placed
for KVM, but it didn't update the PC initialisation for KVM to use
ram_low_size. Fix that now.
Fixes: 71c199c81d29 ("mips_malta: provide ememsize env variable to kernels")
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: Leon Alrae <leon.alrae@imgtec.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
---
hw/mips/mips_malta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index c1f570a79f8f..91c36baa55d6 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -901,7 +901,7 @@ static void main_cpu_reset(void *opaque)
if (kvm_enabled()) {
/* Start running from the bootloader we wrote to end of RAM */
- env->active_tc.PC = 0x40000000 + loaderparams.ram_size;
+ env->active_tc.PC = 0x40000000 + loaderparams.ram_low_size;
}
}
--
2.4.9
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/mips_malta: Fix KVM PC initialisation
2015-10-12 16:54 [Qemu-devel] [PATCH] hw/mips_malta: Fix KVM PC initialisation James Hogan
@ 2015-10-13 15:46 ` Aurelien Jarno
2015-10-16 14:58 ` Leon Alrae
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2015-10-13 15:46 UTC (permalink / raw)
To: James Hogan; +Cc: Leon Alrae, qemu-devel, Paul Burton
On 2015-10-12 17:54, James Hogan wrote:
> Commit 71c199c81d29 ("mips_malta: provide ememsize env variable to
> kernels") changed the meaning of loaderparams.ram_size to be the whole
> of RAM rather than just the low part below where the boot code is placed
> for KVM, but it didn't update the PC initialisation for KVM to use
> ram_low_size. Fix that now.
>
> Fixes: 71c199c81d29 ("mips_malta: provide ememsize env variable to kernels")
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Paul Burton <paul.burton@imgtec.com>
> Cc: Leon Alrae <leon.alrae@imgtec.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> ---
> hw/mips/mips_malta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/mips_malta: Fix KVM PC initialisation
2015-10-12 16:54 [Qemu-devel] [PATCH] hw/mips_malta: Fix KVM PC initialisation James Hogan
2015-10-13 15:46 ` Aurelien Jarno
@ 2015-10-16 14:58 ` Leon Alrae
1 sibling, 0 replies; 3+ messages in thread
From: Leon Alrae @ 2015-10-16 14:58 UTC (permalink / raw)
To: James Hogan, qemu-devel; +Cc: Aurelien Jarno, Paul Burton
On 12/10/15 17:54, James Hogan wrote:
> Commit 71c199c81d29 ("mips_malta: provide ememsize env variable to
> kernels") changed the meaning of loaderparams.ram_size to be the whole
> of RAM rather than just the low part below where the boot code is placed
> for KVM, but it didn't update the PC initialisation for KVM to use
> ram_low_size. Fix that now.
>
> Fixes: 71c199c81d29 ("mips_malta: provide ememsize env variable to kernels")
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Paul Burton <paul.burton@imgtec.com>
> Cc: Leon Alrae <leon.alrae@imgtec.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> ---
> hw/mips/mips_malta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-16 14:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-12 16:54 [Qemu-devel] [PATCH] hw/mips_malta: Fix KVM PC initialisation James Hogan
2015-10-13 15:46 ` Aurelien Jarno
2015-10-16 14:58 ` Leon Alrae
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).