From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn6fX-0005Ze-FV for qemu-devel@nongnu.org; Fri, 16 Oct 2015 11:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zn6fT-0001ub-QL for qemu-devel@nongnu.org; Fri, 16 Oct 2015 11:11:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn6fT-0001uL-La for qemu-devel@nongnu.org; Fri, 16 Oct 2015 11:11:39 -0400 References: <1442261251-32284-1-git-send-email-daniel@fahlgren.se> <1444207751.19086.7.camel@fahlgren-laptop> <5614E149.40000@redhat.com> <1445006813.3872.22.camel@fahlgren-laptop> From: Paolo Bonzini Message-ID: <562113A7.2020807@redhat.com> Date: Fri, 16 Oct 2015 17:11:35 +0200 MIME-Version: 1.0 In-Reply-To: <1445006813.3872.22.camel@fahlgren-laptop> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] watchdog: add support to emulate winbond w83627thf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Daniel Fahlgren Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On 16/10/2015 16:46, Daniel Fahlgren wrote: > The spec can be found at > http://www.alldatasheet.com/datasheet-pdf/pdf/206865/WINBOND/W83627THF.html > > To quote the datasheet about the other features: > > "83627THF is a Winbond LPC I/O product. It integrates the following > major peripheral functions in a chip: the disk driver adapter (FDC), > Serial port (UART), Parallel port (SPP/EPP/ECP), Keyboard controller > (KBC), SIR, Game port, MIDI port, Hardware Monitor, ACPI, On Now Wake-Up > features." > > My reason for implementing this watchdog is that I have a Linux system > image that depends on /dev/watchdog being present. That image only has a > single kernel module for watchdogs enabled which happened to be this > one. So no advantages except diversity and giving the users the option > to choose from different devices. I see. Since you modeled it as an ISA device, it makes sense to extract the watchdog out of the SuperIO chip. Can you write a testcase similar to tests/wdt_ib700-test.c? With that we can accept the patch. Thanks, Paolo