From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn7tX-0004ac-LL for qemu-devel@nongnu.org; Fri, 16 Oct 2015 12:30:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zn7tU-0008NU-GE for qemu-devel@nongnu.org; Fri, 16 Oct 2015 12:30:15 -0400 References: <1443130823-10723-1-git-send-email-jsnow@redhat.com> <561BE4CC.9070705@redhat.com> <20151016122331.GJ10205@stefanha-thinkpad.redhat.com> From: John Snow Message-ID: <56212609.807@redhat.com> Date: Fri, 16 Oct 2015 12:30:01 -0400 MIME-Version: 1.0 In-Reply-To: <20151016122331.GJ10205@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [RFC] transactions: add transaction-wide property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: famz@redhat.com, armbru@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org On 10/16/2015 08:23 AM, Stefan Hajnoczi wrote: > On Mon, Oct 12, 2015 at 12:50:20PM -0400, John Snow wrote: >> Ping -- any consensus on how we should implement the "do-or-die" >> argument for transactions that start block jobs? :) >> >> This patch may look a little hokey in how it boxes arguments, but I can >> re-do it on top of Eric Blake's very official way of boxing arguments, >> when the QAPI dust settles. > > I don't understand what you are trying to do after staring at the email > for 5 minutes. Maybe the other reviewers hit the same problem and > haven't responded. > > What is the problem you're trying to solve? > > Stefan > Sorry... What I am trying to do is to add the transactional blocker property to the *transaction* command and not as an argument to each individual action. There was some discussion on this so I wanted to just send an RFC to show what I had in mind. This series applies on top of Fam's latest series and moves the arguments from each action to a transaction-wide property.