From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnUQQ-0007f6-58 for qemu-devel@nongnu.org; Sat, 17 Oct 2015 12:33:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZnUQP-000782-AI for qemu-devel@nongnu.org; Sat, 17 Oct 2015 12:33:42 -0400 References: <1444680042-13207-1-git-send-email-mreitz@redhat.com> <1444680042-13207-27-git-send-email-mreitz@redhat.com> <20151015112945.GA4302@noname.redhat.com> From: Max Reitz Message-ID: <56227858.7060102@redhat.com> Date: Sat, 17 Oct 2015 18:33:28 +0200 MIME-Version: 1.0 In-Reply-To: <20151015112945.GA4302@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rT3vGWS2r6rJThbmr3xftD2EiEXanF8cG" Subject: Re: [Qemu-devel] [PATCH v6 26/39] blockdev: Allow more options for BB-less BDS tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Alberto Garcia , qemu-block@nongnu.org, John Snow , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rT3vGWS2r6rJThbmr3xftD2EiEXanF8cG Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 15.10.2015 13:29, Kevin Wolf wrote: > Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: >> Most of the options which blockdev_init() parses for both the >> BlockBackend and the root BDS are valid for just the root BDS as well >> (e.g. read-only). This patch allows specifying these options even if n= ot >> creating a BlockBackend. >> >> Signed-off-by: Max Reitz >> --- >> blockdev.c | 160 ++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++--- >> 1 file changed, 154 insertions(+), 6 deletions(-) >=20 >> + >> + /* disk I/O throttling */ >> + if (throttle_enabled(&cfg)) { >> + if (!throttling_group) { >> + throttling_group =3D bdrv_get_node_name(bs); >> + } >> + bdrv_io_limits_enable(bs, throttling_group); >> + bdrv_set_io_limits(bs, &cfg); >> + } >=20 > A while ago we discussed that we want to move throttling to the BB leve= l > eventually. In that case, it might be wiser not to expose it for non-BB= > nodes now. Sounds good. Will do. Max > Otherwise the patch looks good to me. >=20 > Kevin >=20 --rT3vGWS2r6rJThbmr3xftD2EiEXanF8cG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWInhYAAoJEDuxQgLoOKytIUkH/RCroWgwCVf7mE/+0OC5IASC K1pIAdxAIQkKowIsRU5fwJ34BekiR4urAu5I+6us1cV30VUKCiao9RsgJJnnsayN tHdQBoRFf6cDRLyLPu3wtduik2OdAC6Opd2OdHzzmzQ3tXUsw247CKdlg3CgtOT3 cRuQFUL+aXGVT5xVFdDDPSr4xjAyo4TOP/JJcFyZloKMln7kCY4Jqj/mDijsZNsG B8eI4cMzSP39O/wRPI/ISwXRPuUH2QDHlcpDGGw9sm3HTpGgH0rattS2am0WoGuC lWQ/5sMKQdAjpQuV4g2CZTBw+xDOXSx8Tn0N4Unr3EOdU7Vi0kvpIBcFxLEjK0E= =7fic -----END PGP SIGNATURE----- --rT3vGWS2r6rJThbmr3xftD2EiEXanF8cG--