From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo1gy-0002i0-7k for qemu-devel@nongnu.org; Mon, 19 Oct 2015 00:05:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zo1gv-0004Dl-1L for qemu-devel@nongnu.org; Mon, 19 Oct 2015 00:05:00 -0400 Received: from mga09.intel.com ([134.134.136.24]:58140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo1gu-0004De-SA for qemu-devel@nongnu.org; Mon, 19 Oct 2015 00:04:56 -0400 References: <1445216059-88521-1-git-send-email-guangrong.xiao@linux.intel.com> <1445216059-88521-24-git-send-email-guangrong.xiao@linux.intel.com> <20151018171551.GA9847@redhat.com> From: Xiao Guangrong Message-ID: <56246A6B.6080904@linux.intel.com> Date: Mon, 19 Oct 2015 11:58:35 +0800 MIME-Version: 1.0 In-Reply-To: <20151018171551.GA9847@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 23/33] nvdimm acpi: init the address region used by NVDIMM ACPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 10/19/2015 01:15 AM, Michael S. Tsirkin wrote: > On Mon, Oct 19, 2015 at 08:54:09AM +0800, Xiao Guangrong wrote: >> +typedef struct nfit_spa nfit_spa; > > There are still multiple coding style violations. Pls fix all code to > match coding style. I commented on this before. > Er, i thought what you disliked is just function names... Now I know i was misunderstanding it and sorry for wasting your time on it. I will change all structs in this patch that： struct nfit_spa －> struct nvdimm_nfit_spa struct nfit_memdev -> struct nvdimm_nfit_memdev struct nfit_dcr nfit_dcr -> struct nvdimm_nfit_dcr nfit_dcr; and also copy the spec reference from where these struct was used to where these struct was defined.