From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo1nA-0004mF-VT for qemu-devel@nongnu.org; Mon, 19 Oct 2015 00:11:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zo1n7-0005Sa-Pg for qemu-devel@nongnu.org; Mon, 19 Oct 2015 00:11:24 -0400 Received: from mga09.intel.com ([134.134.136.24]:49859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo1n7-0005SW-Bs for qemu-devel@nongnu.org; Mon, 19 Oct 2015 00:11:21 -0400 References: <1445216059-88521-1-git-send-email-guangrong.xiao@linux.intel.com> <1445216059-88521-28-git-send-email-guangrong.xiao@linux.intel.com> <20151018201620-mutt-send-email-mst@redhat.com> From: Xiao Guangrong Message-ID: <56246BE0.2040901@linux.intel.com> Date: Mon, 19 Oct 2015 12:04:48 +0800 MIME-Version: 1.0 In-Reply-To: <20151018201620-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 27/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 10/19/2015 01:16 AM, Michael S. Tsirkin wrote: > On Mon, Oct 19, 2015 at 08:54:13AM +0800, Xiao Guangrong wrote: >> Check if the input Arg3 is valid then store it into dsm_in if needed >> >> Signed-off-by: Xiao Guangrong >> --- >> hw/acpi/nvdimm.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c >> index 7e99889..b211b8b 100644 >> --- a/hw/acpi/nvdimm.c >> +++ b/hw/acpi/nvdimm.c >> @@ -624,10 +624,29 @@ static void nvdimm_build_acpi_devices(NVDIMMState *state, GSList *device_list, >> >> method = aml_method_serialized("NCAL", 4); >> { >> + Aml *ifctx; >> + >> aml_append(method, aml_store(aml_arg(0), aml_name("HDLE"))); >> aml_append(method, aml_store(aml_arg(1), aml_name("REVS"))); >> aml_append(method, aml_store(aml_arg(2), aml_name("FUNC"))); >> >> + /* Arg3 is passed as Package and it has one element? */ >> + ifctx = aml_if(aml_and(aml_equal(aml_object_type(aml_arg(3)), >> + aml_int(4)), >> + aml_equal(aml_sizeof(aml_arg(3)), >> + aml_int(1)))); >> + { >> + /* Local0 = Index(Arg3, 0) */ >> + aml_append(ifctx, aml_store(aml_index(aml_arg(3), aml_int(0)), >> + aml_local(0))); >> + /* Local3 = DeRefOf(Local0) */ >> + aml_append(ifctx, aml_store(aml_derefof(aml_local(0)), >> + aml_local(3))); >> + /* ARG3 = Local3 */ >> + aml_append(ifctx, aml_store(aml_local(3), aml_name("ARG3"))); >> + } >> + aml_append(method, ifctx); >> + >> aml_append(method, aml_store(aml_int(NOTIFY_VALUE), aml_name("NOTI"))); >> >> aml_append(method, aml_store(aml_name("RLEN"), aml_local(6))); > > I commented on this patch on v3. > It doesn't look like this was addressed. > Ah... I see no one commented this patch ([PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method) on v3. Do you mean we need more and better comment to explain arg3? Or anything else?