From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo5DN-0005UL-QC for qemu-devel@nongnu.org; Mon, 19 Oct 2015 03:50:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zo5DH-0000ZV-A3 for qemu-devel@nongnu.org; Mon, 19 Oct 2015 03:50:38 -0400 Received: from mga14.intel.com ([192.55.52.115]:5039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo5DH-0000ZO-3y for qemu-devel@nongnu.org; Mon, 19 Oct 2015 03:50:35 -0400 References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-23-git-send-email-guangrong.xiao@linux.intel.com> <20151019095612-mutt-send-email-mst@redhat.com> <56249B59.1040103@linux.intel.com> <20151019103754-mutt-send-email-mst@redhat.com> From: Xiao Guangrong Message-ID: <56249F4D.10709@linux.intel.com> Date: Mon, 19 Oct 2015 15:44:13 +0800 MIME-Version: 1.0 In-Reply-To: <20151019103754-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 10/19/2015 03:39 PM, Michael S. Tsirkin wrote: > On Mon, Oct 19, 2015 at 03:27:21PM +0800, Xiao Guangrong wrote: >>>> + nvdimm_init_memory_state(&pcms->nvdimm_memory, system_memory, machine, >>>> + TARGET_PAGE_SIZE); >>>> + >>> >>> Shouldn't this be conditional on presence of the nvdimm device? >>> >> >> We will enable hotplug on nvdimm devices in the near future once Linux driver is >> ready. I'd keep it here for future development. > > No, I don't think we should add stuff unconditionally. If not nvdimm, > some other flag should indicate user intends to hotplug things. > Actually, it is not unconditionally which is called if parameter "-m aaa, maxmem=bbb" (aaa < bbb) is used. It is on the some path of memoy-hotplug initiation.