From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoCBa-0007f4-TH for qemu-devel@nongnu.org; Mon, 19 Oct 2015 11:17:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoCBY-0004qN-4d for qemu-devel@nongnu.org; Mon, 19 Oct 2015 11:17:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoCBX-0004q2-Th for qemu-devel@nongnu.org; Mon, 19 Oct 2015 11:17:16 -0400 References: <1445246284-21137-1-git-send-email-kraxel@redhat.com> From: Laszlo Ersek Message-ID: <56250978.3090606@redhat.com> Date: Mon, 19 Oct 2015 17:17:12 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc_Mar=c3=ad?= Cc: Peter Maydell , Gerd Hoffmann , QEMU Developers On 10/19/15 13:12, Peter Maydell wrote: > On 19 October 2015 at 10:17, Gerd Hoffmann wrote: >> Hi, >> >> As promised last week I've picked up the fw_cfg patches which are read= y >> to go, so here comes the pull request for them. Headline feature is >> the fw_cfg dam support fo course, enabled for arm and x86. Also small >> fixes and an option to add string fw_cfg entries via command line. >> >> please pull, >> Gerd >> >> The following changes since commit 40fe17bea478793fc9106a630fa3610dad5= 1f939: >> >> hw/ide/ahci.c: Fix shift left into sign bit (2015-10-18 11:00:40 +01= 00) >> >> are available in the git repository at: >> >> git://git.kraxel.org/qemu tags/pull-fw_cfg-20151019-1 >> >> for you to fetch changes up to 7b0eec285d447057405df73beae78c8e8aeb979= 3: >> >> fw_cfg: Define a static signature to be returned on DMA port reads (= 2015-10-19 11:00:50 +0200) >> >> ---------------------------------------------------------------- >> fw_cfg: add dma interface, add strings via cmdline. >> >> ---------------------------------------------------------------- >=20 > Hi. I'm afraid this fails 'make check': >=20 > TEST: tests/fw_cfg-test... (pid=3D17533) > /i386/fw_cfg/signature: = OK > /i386/fw_cfg/id: = ** > ERROR:/home/petmay01/qemu/tests/fw_cfg-test.c:40:test_fw_cfg_id: > assertion failed (qfw_cfg_get_u32(fw_cfg, FW_CFG_ID) =3D=3D 1): (3 =3D=3D= 1) > FAIL >=20 > (same failure on 64-bit ARM, ppc64be, OSX, 32-bit ARM). Heh, tests. We have tests to keep fixing them. :) Marc, can you add a hunk to patch "Implement fw_cfg DMA interface" that changes the above test to mask out everything but bit 0? I don't think we need to test DMA in the test suite right now (can be done in another series I guess), but DMA's presence shouldn't break the current test. I guess something like this would suffice: diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c index 9be78e9..27f115d 100644 --- a/tests/fw_cfg-test.c +++ b/tests/fw_cfg-test.c @@ -37,7 +37,7 @@ static void test_fw_cfg_signature(void) static void test_fw_cfg_id(void) { - g_assert_cmpint(qfw_cfg_get_u32(fw_cfg, FW_CFG_ID), =3D=3D, 1); + g_assert_cmpint(qfw_cfg_get_u32(fw_cfg, FW_CFG_ID) & 1, =3D=3D, 1); } static void test_fw_cfg_uuid(void) (Sorry if this has been suggested already, trying to catch up with my mailbox...) Thanks Laszlo >=20 > Windows fails to compile: > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function > =E2=80=98fw_cfg_dma_mem_read=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning: > integer constant is too large for =E2=80=98long=E2=80=99 type >=20 > thanks > -- PMM >=20