From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45105)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZoCDK-0002BR-2U
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 11:19:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZoCDJ-0005LQ-C7
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 11:19:06 -0400
References: <1445267389-21846-1-git-send-email-berrange@redhat.com>
	<1445267389-21846-2-git-send-email-berrange@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <562509E0.7060608@redhat.com>
Date: Mon, 19 Oct 2015 17:18:56 +0200
MIME-Version: 1.0
In-Reply-To: <1445267389-21846-2-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/17] crypto: add QCryptoSecret object
 class for password/key handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Josh Durgin <jdurgin@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>, Ronnie Sahlberg <ronniesahlberg@gmail.com>



On 19/10/2015 17:09, Daniel P. Berrange wrote:
> +
> +    switch (secret->format) {
> +    case QCRYPTO_SECRET_FORMAT_UTF8:
> +        if (!g_utf8_validate(input, strlen(input), NULL)) {
> +            error_setg(errp,
> +                       "Data from secret %s is not valid UTF-8",
> +                       secretid);
> +            goto cleanup;
> +        }
> +        output = input;
> +        input = NULL;
> +        break;

Why validate secrets as UTF-8?  In other words why have "utf8" instead
of "binary" as a possible QCryptoSecretFormat?

Paolo