From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoCIg-0000Ym-A1 for qemu-devel@nongnu.org; Mon, 19 Oct 2015 11:24:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoCIc-0006eB-0M for qemu-devel@nongnu.org; Mon, 19 Oct 2015 11:24:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoCIb-0006e1-Rw for qemu-devel@nongnu.org; Mon, 19 Oct 2015 11:24:33 -0400 References: <1445189728-860-1-git-send-email-drjones@redhat.com> From: Laszlo Ersek Message-ID: <56250B2F.7010505@redhat.com> Date: Mon, 19 Oct 2015 17:24:31 +0200 MIME-Version: 1.0 In-Reply-To: <1445189728-860-1-git-send-email-drjones@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] hw/arm/virt: max-cpus init/check fixup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, ehabkost@redhat.com On 10/18/15 19:35, Andrew Jones wrote: > Changes from v1 > . drop the RFC patch "arm_gic_common.h: add gicv2 aliases for defines" [Peter] > . add a patch to cleanup vl.c's max-cpu error message a little [Drew] > . cleanup mach-virt's new error message [Peter] > . make the error message exactly like vl's cleaned up message [Drew] > . add a comment to virt_class_init explaining that we'll further restrict > max_cpus later [Peter] > > --- > > Sorry to be so late getting this simple v2 out. I was trying to > get a new feature (qmp-dump-guest-memory support for arm) posted > before the 2.5 soft freeze (but missed that anyway...) (off-topic) When you do that, please consider extending the "scripts/dump-guest-memory.py" script as well. (This is not even a "nice to have" request -- the script already doesn't support all the target arches on which the QMP command is available (it only supports x86_64), so nothing is lost if you don't extend the script. My only goal is to put the thought in your mind; you decide :)) Thanks! Laszlo > > Andrew Jones (2): > vl: trivial: minor tweaks to a max-cpu error msg > hw/arm/virt: don't use a15memmap directly > > hw/arm/virt.c | 25 +++++++++++++++++++++---- > vl.c | 4 ++-- > 2 files changed, 23 insertions(+), 6 deletions(-) >