From: Leon Alrae <leon.alrae@imgtec.com>
To: Petar Jovanovic <petar.jovanovic@rt-rk.com>,
qemu-devel@nongnu.org, petar.jovanovic@imgtec.com
Subject: Re: [Qemu-devel] [PATCH v2] target-mips: remove wrong checks for recip.fmt and rsqrt.fmt
Date: Mon, 19 Oct 2015 17:40:26 +0100 [thread overview]
Message-ID: <56251CFA.1010508@imgtec.com> (raw)
In-Reply-To: <20151011203059.GA16705@aurel32.net>
On 11/10/15 21:30, Aurelien Jarno wrote:
> (sorry for the late answer)
>
> On 2015-08-26 14:12, Petar Jovanovic wrote:
>> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>>
>> Instructions recip.{s|d} and rsqrt.{s|d} do not require 64-bit FPU neither
>> they require any particular mode for its FPU. This patch removes the checks
>> that may break a program that uses these instructions.
>
> That is correct. That said these instructions do require at least a
> MIPS32R2 or a MIPS64R1 CPU. I guess we should add these checks now that
> check_cop1x do not guard them anymore.
I suspect that this might too restrictive if we take into account also
legacy processors. As far as I know these instructions were already
present in MIPS IV implementations. I think it'll be safer if for the
pre-MIPS32R2 and pre-MIPS64R1 CPUs we keep the check_cop1x. (actually
I'm not certain if check_cop1x is correct, but at least we aren't
relaxing the previous restrictions too much).
Regards,
Leon
next prev parent reply other threads:[~2015-10-19 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 12:12 [Qemu-devel] [PATCH v2] target-mips: remove wrong checks for recip.fmt and rsqrt.fmt Petar Jovanovic
2015-09-02 7:50 ` Leon Alrae
2015-10-11 20:30 ` Aurelien Jarno
2015-10-19 16:40 ` Leon Alrae [this message]
2015-10-19 16:49 ` Leon Alrae
2015-10-31 6:35 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56251CFA.1010508@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=petar.jovanovic@imgtec.com \
--cc=petar.jovanovic@rt-rk.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).