From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoEje-0000hy-BN for qemu-devel@nongnu.org; Mon, 19 Oct 2015 14:00:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoEjb-0001z6-5e for qemu-devel@nongnu.org; Mon, 19 Oct 2015 14:00:38 -0400 Received: from mga01.intel.com ([192.55.52.88]:57191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoEjb-0001yz-0U for qemu-devel@nongnu.org; Mon, 19 Oct 2015 14:00:35 -0400 References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-23-git-send-email-guangrong.xiao@linux.intel.com> <20151019095612-mutt-send-email-mst@redhat.com> <20151019111836.2e830737@igors-macbook-pro.local> <20151019132401-mutt-send-email-mst@redhat.com> From: Xiao Guangrong Message-ID: <56252E44.9050901@linux.intel.com> Date: Tue, 20 Oct 2015 01:54:12 +0800 MIME-Version: 1.0 In-Reply-To: <20151019132401-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Igor Mammedov Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 10/19/2015 06:25 PM, Michael S. Tsirkin wrote: > On Mon, Oct 19, 2015 at 11:18:36AM +0200, Igor Mammedov wrote: >> On Mon, 19 Oct 2015 09:56:12 +0300 >> "Michael S. Tsirkin" wrote: >> >>> On Sun, Oct 11, 2015 at 11:52:54AM +0800, Xiao Guangrong wrote: >> [...] >>>> diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h >>>> index f6bd2c4..aa95961 100644 >>>> --- a/include/hw/mem/nvdimm.h >>>> +++ b/include/hw/mem/nvdimm.h >>>> @@ -15,6 +15,10 @@ >>>> >>>> #include "hw/mem/dimm.h" >>>> >>>> +/* Memory region 0xFF00000 ~ 0xFFF00000 is reserved for NVDIMM >>>> ACPI. */ +#define NVDIMM_ACPI_MEM_BASE 0xFF000000ULL >> Michael, >> >> If it's ok to map control RAM region directly from QEMU at arbitrary >> location > > It's a fair question. Where is it reserved? In which spec? > The region 0xFF00000 ~ 0xFFF00000 is just reserved for vDSM implementation, it is not required by spec.