From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoGlI-0005vf-6E for qemu-devel@nongnu.org; Mon, 19 Oct 2015 16:10:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoGlF-0002Oq-1K for qemu-devel@nongnu.org; Mon, 19 Oct 2015 16:10:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoGlE-0002Om-SH for qemu-devel@nongnu.org; Mon, 19 Oct 2015 16:10:24 -0400 References: <1445256783-28558-1-git-send-email-prasanna.kalever@redhat.com> <1445256783-28558-2-git-send-email-prasanna.kalever@redhat.com> From: Eric Blake Message-ID: <56254E2E.7090705@redhat.com> Date: Mon, 19 Oct 2015 14:10:22 -0600 MIME-Version: 1.0 In-Reply-To: <1445256783-28558-2-git-send-email-prasanna.kalever@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PFqpPrAdnhVHbMIerjKOUD6r3HfHOJUjW" Subject: Re: [Qemu-devel] [PATCH 2/3] block/gluster: rename [server, volname, image] -> [host, volume, path] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pkrempa@redhat.com, stefanha@gmail.com, deepakcs@redhat.com, bharata@linux.vnet.ibm.com, rtalur@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PFqpPrAdnhVHbMIerjKOUD6r3HfHOJUjW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/19/2015 06:13 AM, Prasanna Kumar Kalever wrote: > for example in 'servers' tuple values we use 'server' variable for key = 'host' > in the code, it will be quite messy to have colliding names for variabl= es, > so to maintain better readability and makes it consistent with other ex= isting > code as well as the input keys/options, this patch renames the followin= g > variables > 'server' -> 'host' > 'image' -> 'path' > 'volname' -> 'volume' >=20 > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 54 +++++++++++++++++++++++++++----------------------= ----- > 1 file changed, 27 insertions(+), 27 deletions(-) >=20 As mentioned on 1/3, I suspect you want to reorder your series to put this one first. Seems fairly mechanical. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PFqpPrAdnhVHbMIerjKOUD6r3HfHOJUjW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWJU4uAAoJEKeha0olJ0NqbzoIAKqOyKv55EYo44NTNSjLaLA2 zEHg8kkvQxJcYZnlLm9onmbTZ8jzKegUqquLWKF9Eo5AN1lI/M1SNBf5Mc7gcwTy ZKNvyT6r9YK1IkfVV67CAkJcdVNkquD2QRS3hfeD+kzJexdvJzqLXXou5adK0pDV isR8ztmqY21SzGih/4n/9dONuUCdO+RRpCQDOWlaVuP1edYCfYgd84ofAynFOUB7 gPKcNRzXYaF/f43kleIrzPuCrq1ciWjFWVwlkIrniHjqDMk7LZ63EjmpVad4FVDp 6P6koS3vKTvTUDrusSjTjQAjRKG/r1BRQTiv7vhP3S+0kMY+QLQedj6xIBp2gD8= =C2gV -----END PGP SIGNATURE----- --PFqpPrAdnhVHbMIerjKOUD6r3HfHOJUjW--