From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoH9u-0003G1-R1 for qemu-devel@nongnu.org; Mon, 19 Oct 2015 16:35:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoH9t-0008VM-Vg for qemu-devel@nongnu.org; Mon, 19 Oct 2015 16:35:54 -0400 References: <1445280546-26226-1-git-send-email-mreitz@redhat.com> <1445280546-26226-3-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <56255407.60205@redhat.com> Date: Mon, 19 Oct 2015 14:35:19 -0600 MIME-Version: 1.0 In-Reply-To: <1445280546-26226-3-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UQAvV3JdbV0Sk06pf7TAdRxVsDBiLVT3r" Subject: Re: [Qemu-devel] [PATCH v5 2/6] block: Avoid BlockDriverState.filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UQAvV3JdbV0Sk06pf7TAdRxVsDBiLVT3r Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/19/2015 12:49 PM, Max Reitz wrote: > In places which directly pass a filename to the OS, we should not use > the filename field at all but exact_filename instead (although the > former currently equals the latter if that is set). >=20 > In raw_open_common(), we do not need to access BDS.filename because we > already have a local variable pointing to the filename. >=20 > Signed-off-by: Max Reitz > --- > block.c | 5 +++-- > block/gluster.c | 2 +- > block/raw-posix.c | 8 ++++---- > block/raw-win32.c | 4 ++-- > 4 files changed, 10 insertions(+), 9 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UQAvV3JdbV0Sk06pf7TAdRxVsDBiLVT3r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWJVQHAAoJEKeha0olJ0NqY8sH/RgRq3o1WZbCi4NHNtcBN1Ch VBLkhHCcoPd0V25oGeyuD+dz2nPt7XrJqLeGArycqZnhkzk1CN4D7Iujr/PD+UF1 6TX2SH6bV5asFaWh5ecv+5VY+NPZVEP79PFZC2EMkjbqGm+fQgOLElwrDyx+7ql6 cYadJ1DzSEDbbHx/OiPCBBpPeLrtHwV8FKgjWvReQr1yXsCy/hVDNstk4m82EWbF unWaKL75bkeSpJMFPUbzcfsCeeOJyi0qIQ7NjQviAnftb8Zz+NHV458L8hb7HFkG wME8QKJBPY9rpdhCrsjqJt31PrAWAjnFfUye+kEatQ0Hs8t83LHy/hoh1BZ5Ht0= =NsJP -----END PGP SIGNATURE----- --UQAvV3JdbV0Sk06pf7TAdRxVsDBiLVT3r--