From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoIfE-0007Kb-Qd for qemu-devel@nongnu.org; Mon, 19 Oct 2015 18:12:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoIev-0007xu-VK for qemu-devel@nongnu.org; Mon, 19 Oct 2015 18:12:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoIev-0007xO-Pj for qemu-devel@nongnu.org; Mon, 19 Oct 2015 18:12:01 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 63B21C0C1883 for ; Mon, 19 Oct 2015 22:12:01 +0000 (UTC) References: <1444648509-29179-1-git-send-email-berrange@redhat.com> <1444648509-29179-4-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <56256AB0.7000203@redhat.com> Date: Mon, 19 Oct 2015 16:12:00 -0600 MIME-Version: 1.0 In-Reply-To: <1444648509-29179-4-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eI3lMApRRXoJ35hMITeOk7FMf1MscdJnt" Subject: Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Paolo Bonzini , "Dr. David Alan Gilbert" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eI3lMApRRXoJ35hMITeOk7FMf1MscdJnt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/12/2015 05:14 AM, Daniel P. Berrange wrote: > If the port in the SocketAddress struct is NULL, it can allow > the kernel to automatically select a free port. This is useful > in particular in unit tests to avoid a race trying to find a > free port to run a test case on. >=20 > Signed-off-by: Daniel P. Berrange > --- > util/qemu-sockets.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) >=20 Right now, the qapi documents InetSocketAddress.port as mandatory. Should we relax it to be optional, rather than special-casing the empty string "" to mean no port? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eI3lMApRRXoJ35hMITeOk7FMf1MscdJnt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWJWqwAAoJEKeha0olJ0NqxuYIAKRS8PXwxMOGUvJJBqSVl0rq kuL3TO4nv0pYx/KiUOoSqBhG8mYAKhXwcw+4yga0G/hz4gFqjfbMbTA7wcLE7w0J b4R+43vPGuutdpkbnNjDX36X9ymimYf7uwm771G0oX5Z4RGH/gn9bhSQJ1iQ/HeE uNOWG2zEo3lYy0u3W2h04wtbbcTIYTOBNA0N6TgE9V+diY9WJkPLBUSMbLbaFftg EvDLjvNrKiBsJiQP6zPFv+QHWkeVSkqEd7ygNLwkrxzxU0TZ61vhKF9Mdmv514cq MC7wU6PfNfbMPoZ0Ks0A0OWMmRM2bAGzSUrlBOqGmXkgH4GaiyMI1JQ14inor6w= =NOAO -----END PGP SIGNATURE----- --eI3lMApRRXoJ35hMITeOk7FMf1MscdJnt--