From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoJrz-0000VV-F4 for qemu-devel@nongnu.org; Mon, 19 Oct 2015 19:29:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoJry-0008Kr-HY for qemu-devel@nongnu.org; Mon, 19 Oct 2015 19:29:35 -0400 References: <1445267389-21846-1-git-send-email-berrange@redhat.com> <1445267389-21846-8-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <56257CD4.2010407@redhat.com> Date: Mon, 19 Oct 2015 17:29:24 -0600 MIME-Version: 1.0 In-Reply-To: <1445267389-21846-8-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p9kHj9QKWS5fLiPn87STWuXkKvjJd2n5d" Subject: Re: [Qemu-devel] [PATCH 07/17] qcow2: add a 'keyid' parameter to qcow2 options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Josh Durgin , Ronnie Sahlberg , qemu-block@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --p9kHj9QKWS5fLiPn87STWuXkKvjJd2n5d Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/19/2015 09:09 AM, Daniel P. Berrange wrote: > Add a 'keyid' parameter that refers to the ID of a > QCryptoSecret instance that provides the encryption key. >=20 > $QEMU \ > -object secret,id=3Dsec0,filename=3D/home/berrange/encrypted.pw \ > -drive file=3D/home/berrange/encrypted.qcow2,keyid=3Dsec0 >=20 > Signed-off-by: Daniel P. Berrange > --- > block/qcow2.c | 80 +++++++++++++++++++++++++++++++++++++-------= -------- > block/qcow2.h | 1 + > qapi/block-core.json | 8 ++++-- > 3 files changed, 64 insertions(+), 25 deletions(-) >=20 > +++ b/qapi/block-core.json > @@ -1567,7 +1567,7 @@ > # Driver specific block device options for qcow. > # > # @keyid: #optional ID of the "secret" object providin= g the > -# AES decryption key. > +# AES decryption key (since 2.5) Looks like this line... > # > # Since: 2.5 > ## > @@ -1611,6 +1611,9 @@ > # caches. The interval is in seconds. The defa= ult value > # is 0 and it disables this feature (since 2.5= ) > # > +# @keyid: #optional ID of the "secret" object providin= g the > +# AES decryption key. =2E..and this line should be swapped. > +# > # Since: 1.7 (For qcow, the entire struct is new so @keyid doesn't need versioning; for qcow2, the struct existed since 1.7 and we are extending it in 2.5) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --p9kHj9QKWS5fLiPn87STWuXkKvjJd2n5d Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWJXzUAAoJEKeha0olJ0NqtvYH/ixAuUSKpzxGSMOFuhU8y+My K6FnJAXeT14h6O4HlIF8TcSOyQLTvsCA2fQQKyz74wwD3IfxycsTeYkk2dTMX/7z hmsUeIwXOe37O0IHNYIBFSO1PIsEa1ciZGMyq5pjTYWEnudLP9mp/+HdY9RB0MKY ad8ZEDtv5aho7m/OBhupfkgb/tD/L/+xaoNxYPID5evhJdELy8djnp6OaycskBNn 8EGedW9hRTOcmaOOHZhZ6itAsWKkl/oKCNZ+SH+nAx8e+WNDHqXb30WSSDdMPtcx OU9IQFo7rdU2NrFdVtdF1fedMlWgP/tO8biHrxd85im9J+PHQRGxGnvdfV6mQEY= =Ag4n -----END PGP SIGNATURE----- --p9kHj9QKWS5fLiPn87STWuXkKvjJd2n5d--