From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoQYc-0003tq-Uh for qemu-devel@nongnu.org; Tue, 20 Oct 2015 02:38:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoQYW-0001gN-Sk for qemu-devel@nongnu.org; Tue, 20 Oct 2015 02:38:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoQYW-0001gD-Mf for qemu-devel@nongnu.org; Tue, 20 Oct 2015 02:37:56 -0400 References: <1445154799-31083-1-git-send-email-leonid.bloch@ravellosystems.com> From: Jason Wang Message-ID: <5625E13B.2000009@redhat.com> Date: Tue, 20 Oct 2015 14:37:47 +0800 MIME-Version: 1.0 In-Reply-To: <1445154799-31083-1-git-send-email-leonid.bloch@ravellosystems.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] e1000: Various fixes and registers' implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Bloch , qemu-devel@nongnu.org Cc: Dmitry Fleytman , Leonid Bloch , Shmulik Ladkani On 10/18/2015 03:53 PM, Leonid Bloch wrote: > This series fixes several issues with incorrect packet/octet counting in > e1000's Statistic registers, fixes a bug in the packet address filtering > procedure, and implements many MAC registers that were absent before. > Additionally, some cosmetic changes are made. > > Leonid Bloch (6): > e1000: Cosmetic and alignment fixes > e1000: Trivial implementation of various MAC registers > e1000: Fixing the received/transmitted packets' counters > e1000: Fixing the received/transmitted octets' counters > e1000: Fixing the packet address filtering procedure > e1000: Implementing various counters > > hw/net/e1000.c | 313 ++++++++++++++++++++++++++++++++++++++-------------- > hw/net/e1000_regs.h | 8 +- > 2 files changed, 236 insertions(+), 85 deletions(-) > Looks good to me overall, just few comments in individual patches. A question here, is there any real user/OSes that tries to use those registers? If not, maintain them sees a burden and it's a little bit hard the test them unless unit-test were implemented for those registers. And I'd like to know the test status of this series. At least both windows and linux guest need to be tested. Thanks