From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoQzL-00074y-Um for qemu-devel@nongnu.org; Tue, 20 Oct 2015 03:05:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoQzG-00009p-7B for qemu-devel@nongnu.org; Tue, 20 Oct 2015 03:05:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoQzG-00009X-1b for qemu-devel@nongnu.org; Tue, 20 Oct 2015 03:05:34 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id DE6B8461C3 for ; Tue, 20 Oct 2015 07:05:32 +0000 (UTC) References: <1445259878-3921-1-git-send-email-vyasevic@redhat.com> From: Jason Wang Message-ID: <5625E7B8.1030905@redhat.com> Date: Tue, 20 Oct 2015 15:05:28 +0800 MIME-Version: 1.0 In-Reply-To: <1445259878-3921-1-git-send-email-vyasevic@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] net: Remove duplicate data from query-rx-filter on multiqueue net devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Yasevich , qemu-devel@nongnu.org Cc: stefanha@redhat.com On 10/19/2015 09:04 PM, Vladislav Yasevich wrote: > When responding to a query-rx-filter command on a multiqueue > netdev, qemu reports the data for each queue. The data, however, > is not per-queue, but per device and the same data is reported > multiple times. This causes confusion and may also cause extra > unnecessary processing when looking at the data. > > Commit 638fb14169 (net: Make qmp_query_rx_filter() with name argument > more obvious) partially addresses this issue, by limiting the output > when the name is specified. However, when the name is not specified, > the issue still persists. > > Signed-off-by: Vladislav Yasevich > --- > net/net.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/net/net.c b/net/net.c > index 39af893..a8cfeba 100644 > --- a/net/net.c > +++ b/net/net.c > @@ -1219,6 +1219,12 @@ RxFilterInfoList *qmp_query_rx_filter(bool has_name, const char *name, > continue; > } > > + /* only query information on queue 0 since the info is per nic, > + * not per queue > + */ > + if (nc->queue_index != 0) > + continue; > + > if (nc->info->query_rx_filter) { > info = nc->info->query_rx_filter(nc); > entry = g_malloc0(sizeof(*entry)); Applied in https://github.com/jasowang/qemu/commits/net Thanks