From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoRDt-0008ME-37 for qemu-devel@nongnu.org; Tue, 20 Oct 2015 03:20:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoRDp-0006ca-Nt for qemu-devel@nongnu.org; Tue, 20 Oct 2015 03:20:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoRDp-0006cP-GL for qemu-devel@nongnu.org; Tue, 20 Oct 2015 03:20:37 -0400 References: <1445305886-11901-1-git-send-email-yanghy@cn.fujitsu.com> From: Jason Wang Message-ID: <5625EB3F.2030605@redhat.com> Date: Tue, 20 Oct 2015 15:20:31 +0800 MIME-Version: 1.0 In-Reply-To: <1445305886-11901-1-git-send-email-yanghy@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] net: make iov_to_buf take right size argument in nc_sendv_compat() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: Paolo Bonzini On 10/20/2015 09:51 AM, Yang Hongyang wrote: > We want "buf, sizeof(buf)" here. sizeof(buffer) is the size of a > pointer, which is wrong. > Thanks to Paolo for pointing it out. > > Signed-off-by: Yang Hongyang > Cc: Jason Wang > Cc: Paolo Bonzini > --- > net/net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/net.c b/net/net.c > index 39af893..0c4a012 100644 > --- a/net/net.c > +++ b/net/net.c > @@ -700,7 +700,7 @@ static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, > offset = iov[0].iov_len; > } else { > buffer = buf; > - offset = iov_to_buf(iov, iovcnt, 0, buffer, sizeof(buffer)); > + offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); > } > > if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { Both two patches were applied in: https://github.com/jasowang/qemu/commits/net Thanks