From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoRwp-0004uW-8x for qemu-devel@nongnu.org; Tue, 20 Oct 2015 04:07:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoRwj-0006lS-BP for qemu-devel@nongnu.org; Tue, 20 Oct 2015 04:07:07 -0400 Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:34338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoRwj-0006lN-3e for qemu-devel@nongnu.org; Tue, 20 Oct 2015 04:07:01 -0400 Received: by lfaz124 with SMTP id z124so1584693lfa.1 for ; Tue, 20 Oct 2015 01:07:00 -0700 (PDT) Sender: Paolo Bonzini References: <1445305886-11901-1-git-send-email-yanghy@cn.fujitsu.com> <5625EB3F.2030605@redhat.com> From: Paolo Bonzini Message-ID: <5625F620.1060102@redhat.com> Date: Tue, 20 Oct 2015 10:06:56 +0200 MIME-Version: 1.0 In-Reply-To: <5625EB3F.2030605@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] net: make iov_to_buf take right size argument in nc_sendv_compat() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , Yang Hongyang , qemu-devel@nongnu.org On 20/10/2015 09:20, Jason Wang wrote: > > > On 10/20/2015 09:51 AM, Yang Hongyang wrote: >> We want "buf, sizeof(buf)" here. sizeof(buffer) is the size of a >> pointer, which is wrong. >> Thanks to Paolo for pointing it out. >> >> Signed-off-by: Yang Hongyang >> Cc: Jason Wang >> Cc: Paolo Bonzini >> --- >> net/net.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/net.c b/net/net.c >> index 39af893..0c4a012 100644 >> --- a/net/net.c >> +++ b/net/net.c >> @@ -700,7 +700,7 @@ static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, >> offset = iov[0].iov_len; >> } else { >> buffer = buf; >> - offset = iov_to_buf(iov, iovcnt, 0, buffer, sizeof(buffer)); >> + offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); >> } >> >> if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { > > Both two patches were applied in: > > https://github.com/jasowang/qemu/commits/net > > Thanks Thanks! Paolo