From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Fedin <p.fedin@samsung.com>,
"'Daniel P. Berrange'" <berrange@redhat.com>,
qemu-devel@nongnu.org
Cc: "'Markus Armbruster'" <armbru@redhat.com>,
"'Andreas Färber'" <afaerber@suse.de>
Subject: Re: [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling
Date: Tue, 20 Oct 2015 14:15:53 +0200 [thread overview]
Message-ID: <56263079.6070306@redhat.com> (raw)
In-Reply-To: <025701d10b2b$d833d5b0$889b8110$@samsung.com>
On 20/10/2015 13:38, Pavel Fedin wrote:
> Hello! Is there any progress on this?
> 6/7 significantly improves startup performance, i'd like to have it accepted.
Me too. :)
I am waiting for Andreas, since he's the maintainer for QOM.
Paolo
>
>> -----Original Message-----
>> From: qemu-devel-bounces+p.fedin=samsung.com@nongnu.org [mailto:qemu-devel-
>> bounces+p.fedin=samsung.com@nongnu.org] On Behalf Of Pavel Fedin
>> Sent: Wednesday, October 14, 2015 9:58 AM
>> To: 'Daniel P. Berrange'; qemu-devel@nongnu.org
>> Cc: 'Paolo Bonzini'; 'Markus Armbruster'; 'Andreas Färber'
>> Subject: Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling
>>
>> Hello!
>>
>>> This series introduces a concept of object property iterators
>>> to QOM so callers are insulated from the specific data structures
>>> used for storing properties against objects/classes. It then
>>> converts Object to use a GHashTable for storing properties.
>>> Finally it introduces ObjectClass properties.
>>
>> Tested-by: Pavel Fedin <p.fedin@samsung.com>
>>
>>> Probably the only controversial thing is the item Pavel points
>>> out about object_child_foreach iterators now being forbidden
>>> from modifying the object composition tree.
>>
>> As i already wrote, current code does not modify the tree. If necessary, it is possible to
>> work around (e. g. make a decision about modification, stop iteration, then do the
>> modification). I think this would pop up anyway if we change list to anything else. IMHO it's
>> better just to acknowledge that we should not modify our tree inside iterator.
>>
>> Kind regards,
>> Pavel Fedin
>> Expert Engineer
>> Samsung Electronics Research center Russia
>>
>
>
next prev parent reply other threads:[~2015-10-20 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 11:38 [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling Pavel Fedin
2015-10-20 12:15 ` Paolo Bonzini [this message]
2015-10-20 12:25 ` Daniel P. Berrange
2015-10-20 12:38 ` Andreas Färber
2015-10-20 12:54 ` Daniel P. Berrange
2015-10-20 13:17 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56263079.6070306@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=p.fedin@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).