From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoVpk-0000bZ-St for qemu-devel@nongnu.org; Tue, 20 Oct 2015 08:16:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoVpg-0003bH-Gb for qemu-devel@nongnu.org; Tue, 20 Oct 2015 08:16:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoVpg-0003b8-3W for qemu-devel@nongnu.org; Tue, 20 Oct 2015 08:16:00 -0400 References: <025701d10b2b$d833d5b0$889b8110$@samsung.com> From: Paolo Bonzini Message-ID: <56263079.6070306@redhat.com> Date: Tue, 20 Oct 2015 14:15:53 +0200 MIME-Version: 1.0 In-Reply-To: <025701d10b2b$d833d5b0$889b8110$@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Fedin , "'Daniel P. Berrange'" , qemu-devel@nongnu.org Cc: 'Markus Armbruster' , =?UTF-8?Q?'Andreas_F=c3=a4rber'?= On 20/10/2015 13:38, Pavel Fedin wrote: > Hello! Is there any progress on this? > 6/7 significantly improves startup performance, i'd like to have it ac= cepted. Me too. :) I am waiting for Andreas, since he's the maintainer for QOM. Paolo >=20 >> -----Original Message----- >> From: qemu-devel-bounces+p.fedin=3Dsamsung.com@nongnu.org [mailto:qemu= -devel- >> bounces+p.fedin=3Dsamsung.com@nongnu.org] On Behalf Of Pavel Fedin >> Sent: Wednesday, October 14, 2015 9:58 AM >> To: 'Daniel P. Berrange'; qemu-devel@nongnu.org >> Cc: 'Paolo Bonzini'; 'Markus Armbruster'; 'Andreas F=C3=A4rber' >> Subject: Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object pr= operty handling >> >> Hello! >> >>> This series introduces a concept of object property iterators >>> to QOM so callers are insulated from the specific data structures >>> used for storing properties against objects/classes. It then >>> converts Object to use a GHashTable for storing properties. >>> Finally it introduces ObjectClass properties. >> >> Tested-by: Pavel Fedin >> >>> Probably the only controversial thing is the item Pavel points >>> out about object_child_foreach iterators now being forbidden >>> from modifying the object composition tree. >> >> As i already wrote, current code does not modify the tree. If necessa= ry, it is possible to >> work around (e. g. make a decision about modification, stop iteration,= then do the >> modification). I think this would pop up anyway if we change list to a= nything else. IMHO it's >> better just to acknowledge that we should not modify our tree inside i= terator. >> >> Kind regards, >> Pavel Fedin >> Expert Engineer >> Samsung Electronics Research center Russia >> >=20 >=20