From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoWnC-0005ah-WD for qemu-devel@nongnu.org; Tue, 20 Oct 2015 09:17:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoWn5-0005Yd-D8 for qemu-devel@nongnu.org; Tue, 20 Oct 2015 09:17:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:52937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoWn5-0005YD-6R for qemu-devel@nongnu.org; Tue, 20 Oct 2015 09:17:23 -0400 References: <025701d10b2b$d833d5b0$889b8110$@samsung.com> <56263079.6070306@redhat.com> <562635D3.9010501@suse.de> <20151020125434.GI14616@redhat.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <56263EE0.8060607@suse.de> Date: Tue, 20 Oct 2015 15:17:20 +0200 MIME-Version: 1.0 In-Reply-To: <20151020125434.GI14616@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Paolo Bonzini , Pavel Fedin , qemu-devel@nongnu.org, 'Markus Armbruster' Am 20.10.2015 um 14:54 schrieb Daniel P. Berrange: > On Tue, Oct 20, 2015 at 02:38:43PM +0200, Andreas F=C3=A4rber wrote: >> Two problems apart from time: 1) Discussions about iterator design, 2) >> lack of test cases, and that applies to iterator-less v2, too. Circles >> back to me (or someone) looking into qom-proplist test. >=20 > FYI in the v4 posting, I added to the check-qom-proplist.c test case > to cover the new iterator APIs. I further added to it in the later > patches to cover the iteration of properties against classes. The v4 > also has the alternative iterator design that Markus / Paolo preferred, > that avoids use of callback functions. >=20 > I can further test cases to do more coverage of object proprty handling > wrt to classes, if you want me to. No, if that is sorted out now, I'll drop v2 and need to review v4. Cheers, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N= =C3=BCrnberg)