qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	famz@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [RFC] transactions: add transaction-wide property
Date: Tue, 20 Oct 2015 11:55:30 -0400	[thread overview]
Message-ID: <562663F2.5060606@redhat.com> (raw)
In-Reply-To: <87zizfxqr8.fsf@blackfin.pond.sub.org>



On 10/19/2015 03:27 AM, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
> 
>> On 10/16/2015 08:23 AM, Stefan Hajnoczi wrote:
>>> On Mon, Oct 12, 2015 at 12:50:20PM -0400, John Snow wrote:
>>>> Ping -- any consensus on how we should implement the "do-or-die"
>>>> argument for transactions that start block jobs? :)
>>>>
>>>> This patch may look a little hokey in how it boxes arguments, but I can
>>>> re-do it on top of Eric Blake's very official way of boxing arguments,
>>>> when the QAPI dust settles.
>>>
>>> I don't understand what you are trying to do after staring at the email
>>> for 5 minutes.  Maybe the other reviewers hit the same problem and
>>> haven't responded.
>>>
>>> What is the problem you're trying to solve?
>>>
>>> Stefan
>>>
>>
>> Sorry...
>>
>> What I am trying to do is to add the transactional blocker property to
>> the *transaction* command and not as an argument to each individual action.
>>
>> There was some discussion on this so I wanted to just send an RFC to
>> show what I had in mind.
> 
> Was it the discussion on @transactional-cancel?  I'm on record
> supporting it per transaction rather than per action:
> Message-ID: <87mvwd8k9q.fsf@blackfin.pond.sub.org>
> http://lists.gnu.org/archive/html/qemu-devel/2015-09/msg05948.html
> 

Yes, this is the patch trying to illustrate that. I wrote it as an RFC
that sits on top of Fam's v7, to highlight the changes between his and
my approaches.

>> This series applies on top of Fam's latest series and moves the
>> arguments from each action to a transaction-wide property.

  parent reply	other threads:[~2015-10-20 15:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 21:40 [Qemu-devel] [RFC] transactions: add transaction-wide property John Snow
2015-10-12 16:50 ` John Snow
2015-10-16 12:23   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-10-16 16:30     ` John Snow
2015-10-19  7:27       ` Markus Armbruster
2015-10-20  5:16         ` Fam Zheng
2015-10-20 15:55         ` John Snow [this message]
2015-10-20  7:26 ` [Qemu-devel] " Fam Zheng
2015-10-20 19:05   ` John Snow
2015-10-20 20:12 ` Eric Blake
2015-10-20 20:42   ` John Snow
2015-10-20 20:18 ` John Snow
2015-10-21 13:55   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562663F2.5060606@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).