From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Jens Freimann <jfrei@linux.vnet.ibm.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches
Date: Tue, 20 Oct 2015 21:01:59 +0200 [thread overview]
Message-ID: <56268FA7.4020802@de.ibm.com> (raw)
In-Reply-To: <CAFEAcA-j5NF5qZrW4ZMKpMjgHYHW5LCe0jUW7_BG5OOtsK1j-g@mail.gmail.com>
Am 20.10.2015 um 17:35 schrieb Peter Maydell:
> On 20 October 2015 at 16:00, Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>> The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201:
>>
>> Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1' into staging (2015-10-20 12:56:45 +0100)
>>
>> are available in the git repository at:
>>
>> git://github.com/cohuck/qemu tags/s390x-20151020
>>
>> for you to fetch changes up to bde5d1bcb63973802c21183d730e0ea7c0ae227c:
>>
>> s390x/cmma: clean up cmma reset (2015-10-20 16:21:01 +0200)
>>
>> ----------------------------------------------------------------
>> More s390x patches. The first ones are fixes: A regression, missed
>> compat and a missed part of the SIMD support. The others contain
>> optimizations and cleanup.
>>
>> ----------------------------------------------------------------
>
> Hi; I'm afraid this fails to build with clang:
> /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-virtio-ccw.c:38:12:
> error: duplicate 'const' declaration specifier
> [-Werror,-Wduplicate-decl-specifier]
> const char const *reset_dev_types[] = {
> ^
>
>
>
> Did you mean "const char * const" ? (I always have trouble with this
> corner of C syntax...)
"const char * const" looks right, as the pointer and the data is const.
When fixing, you might also add "static" (please double check)
Christian
prev parent reply other threads:[~2015-10-20 19:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 15:00 [Qemu-devel] [PULL 0/9] Next set of s390x patches Cornelia Huck
2015-10-20 15:00 ` [Qemu-devel] [PULL 1/9] util/qemu-config: fix missing machine command line options Cornelia Huck
2015-10-20 15:00 ` [Qemu-devel] [PULL 2/9] s390x/virtio-ccw: fix 2.4 virtio compat Cornelia Huck
2015-10-20 15:00 ` [Qemu-devel] [PULL 3/9] s390x/kvm: Fix vector validity bit in device machine checks Cornelia Huck
2015-10-20 15:00 ` [Qemu-devel] [PULL 4/9] s390x: flagify mcic values Cornelia Huck
2015-10-20 15:00 ` [Qemu-devel] [PULL 5/9] s390x: unify device reset during subsystem_reset() Cornelia Huck
2015-10-20 15:00 ` [Qemu-devel] [PULL 6/9] s390x/ipl: we always have an ipl device Cornelia Huck
2015-10-20 15:00 ` [Qemu-devel] [PULL 7/9] s390x: machine reset function with new ipl cpu handling Cornelia Huck
2015-10-20 15:00 ` [Qemu-devel] [PULL 8/9] s390x: reset crypto only on clear reset and QEMU reset Cornelia Huck
2015-10-20 15:00 ` [Qemu-devel] [PULL 9/9] s390x/cmma: clean up cmma reset Cornelia Huck
2015-10-20 15:35 ` [Qemu-devel] [PULL 0/9] Next set of s390x patches Peter Maydell
2015-10-20 16:50 ` Cornelia Huck
2015-10-21 7:04 ` David Hildenbrand
2015-10-20 19:01 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56268FA7.4020802@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).