From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZocAo-00087i-1C for qemu-devel@nongnu.org; Tue, 20 Oct 2015 15:02:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZocAj-0000JI-1P for qemu-devel@nongnu.org; Tue, 20 Oct 2015 15:02:13 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:38677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZocAi-0000IK-NJ for qemu-devel@nongnu.org; Tue, 20 Oct 2015 15:02:08 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 20 Oct 2015 20:02:04 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 36EAC17D8059 for ; Tue, 20 Oct 2015 20:02:10 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t9KJ21UH50725072 for ; Tue, 20 Oct 2015 19:02:01 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t9KJ20Od008456 for ; Tue, 20 Oct 2015 13:02:01 -0600 References: <1445353225-16775-1-git-send-email-cornelia.huck@de.ibm.com> From: Christian Borntraeger Message-ID: <56268FA7.4020802@de.ibm.com> Date: Tue, 20 Oct 2015 21:01:59 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Cornelia Huck Cc: Jens Freimann , QEMU Developers , Alexander Graf Am 20.10.2015 um 17:35 schrieb Peter Maydell: > On 20 October 2015 at 16:00, Cornelia Huck wrote: >> The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201: >> >> Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1' into staging (2015-10-20 12:56:45 +0100) >> >> are available in the git repository at: >> >> git://github.com/cohuck/qemu tags/s390x-20151020 >> >> for you to fetch changes up to bde5d1bcb63973802c21183d730e0ea7c0ae227c: >> >> s390x/cmma: clean up cmma reset (2015-10-20 16:21:01 +0200) >> >> ---------------------------------------------------------------- >> More s390x patches. The first ones are fixes: A regression, missed >> compat and a missed part of the SIMD support. The others contain >> optimizations and cleanup. >> >> ---------------------------------------------------------------- > > Hi; I'm afraid this fails to build with clang: > /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-virtio-ccw.c:38:12: > error: duplicate 'const' declaration specifier > [-Werror,-Wduplicate-decl-specifier] > const char const *reset_dev_types[] = { > ^ > > > > Did you mean "const char * const" ? (I always have trouble with this > corner of C syntax...) "const char * const" looks right, as the pointer and the data is const. When fixing, you might also add "static" (please double check) Christian