From: Eric Blake <eblake@redhat.com>
To: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pkrempa@redhat.com, stefanha@gmail.com,
deepakcs@redhat.com, bharata@linux.vnet.ibm.com,
rtalur@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path]
Date: Wed, 21 Oct 2015 07:58:26 -0600 [thread overview]
Message-ID: <56279A02.8060604@redhat.com> (raw)
In-Reply-To: <1445434451-3439-1-git-send-email-prasanna.kalever@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On 10/21/2015 07:34 AM, Prasanna Kumar Kalever wrote:
Missing a 0/3 cover letter; you may want to do:
git config format.coverLetter auto
so that you don't forget it next time.
> it will be quite messy to have colliding names for variables, so to maintain
> better readability and make it consistent with other existing code as well as
> the input keys/options which will be introduced by next couple of patches, this
> patch renames the following variables
> 'server' -> 'host'
> 'image' -> 'path'
> 'volname' -> 'volume'
>
> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
> ---
> block/gluster.c | 54 +++++++++++++++++++++++++++---------------------------
> 1 file changed, 27 insertions(+), 27 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-21 13:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 13:34 [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path] Prasanna Kumar Kalever
2015-10-21 13:34 ` [Qemu-devel] [PATCH v2 2/3] block/gluster: code cleanup Prasanna Kumar Kalever
2015-10-21 14:00 ` Eric Blake
2015-10-21 13:34 ` [Qemu-devel] [PATCH v9 3/3] block/gluster: add support for multiple gluster servers Prasanna Kumar Kalever
2015-10-22 7:03 ` Peter Krempa
2015-10-21 13:58 ` Eric Blake [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-11-10 9:09 [Qemu-devel] [PATCH 0/3] " Prasanna Kumar Kalever
2015-11-10 9:09 ` [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path] Prasanna Kumar Kalever
2015-11-10 15:28 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56279A02.8060604@redhat.com \
--to=eblake@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=deepakcs@redhat.com \
--cc=kwolf@redhat.com \
--cc=pkrempa@redhat.com \
--cc=prasanna.kalever@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rtalur@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).